Repository navigation
Expose additionalData in SignUp and SignIn render props - #119
ThaminduDilshan merged 1 commit into
Conversation
🔀 Cross-SDK feature parity, no ports neededThis pull request is labelled |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
1c3a377 to
573a034
Compare
Signed-off-by: Sadeesha Sathmina <sadeesha@wso2.com>
573a034 to
26068d6
Compare
Purpose
A consumer that renders sign-up or sign-in through render props (React
childrenfunction / Vue default scoped slot) has no way to read the current step'sadditionalData. The default UI already uses it (e.g.sourcelookups forKEY_VALUE_LIST, such as account-linking prompts), but custom UIs like aSignUpBoxcan't. This exposes it in both sign-up and sign-in so the two stay consistent. Nuxt re-uses the Vue component and forwards its slot; the Next.jsSignUpnow forwardschildrentoBaseSignUpso Next.js consumers can use render props too.Approach
additionalData: Record<string, unknown>toBaseSignUpRenderPropsandBaseSignInRenderPropsin React and Vue. Sign-up reads it from the current flow step'sdata.additionalData; sign-in passes through its existingadditionalDataprop.{}(asSignInandBaseAcceptInvitealready do), so consumers don't need a null check.childrenin the Next.jsSignUp.Related Issues
Related PRs
SignUpBoxneeds this to renderKEY_VALUE_LIST,COPYABLE_TEXTandQR_CODEin sign-up flows)Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks
Summary by CodeRabbit