Repository navigation
KHA-1180: Split the stage overlay body so Xcode 26.3 can type-check it - #31
Merged
Merged
Conversation
The last three nightlies (runs 39105184728, 39213583234, 39382572907) failed in both CI and E2E: Xcode 26.3 gave up on StageView.standardBody with "unable to type-check this expression in reasonable time". The desktop add/remove/reorder work had grown that one result-builder body past the solver's limit. Xcode 27 still accepted it, taking 929 ms. The per-plate view, the drawn scene, and the hover, tap and keyboard-move handlers now live in their own methods, sharing the stack-wide values through PlateStack. The code moved without change, so behaviour is the same. With Xcode 27 the slowest body in the file now type-checks in 41 ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly failures (e.g. https://github.com/thomplth/debut/actions/runs/39382572907):
StageView.standardBodyexceeded the Xcode 26.3 type-checker limit. Splits it intostagePlate,stackSceneand handler methods with no change in behaviour; locally the worst body drops from 929 ms to 41 ms.