Skip to content

audio: base_fw: bound host pipelines_count in pipeline list query #11276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmleman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: base_fw: bound host pipelines_count in pipeline list query #11276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/audio/base_fw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// Copyright(c) 2024 Intel Corporation.
//

#include <stdint.h>

#include <sof/audio/component.h>
#include <sof/ut.h>
#include <sof/tlv.h>
Expand Down Expand Up @@ -532,10 +534,16 @@ __cold static int basefw_pipeline_list_info_get(uint32_t *data_offset, char *dat
pipeline_data = ipc4_get_pipeline_data_wrapper();
ppl_data->pipelines_count = 0;

for (int ppl = 0; ppl < pipeline_data->pipelines_count; ppl++) {
if (pipeline_data->pipelines_count > UINT8_MAX + 1U) {
tr_err(&ipc_tr, "pipelines_count %u exceeds instance ID scan limit %u",
pipeline_data->pipelines_count, UINT8_MAX + 1U);
return IPC4_ERROR_INVALID_PARAM;
}

for (uint32_t ppl = 0; ppl < pipeline_data->pipelines_count; ppl++) {
ipc_pipe = ipc_get_pipeline_by_id(ipc, ppl);
if (!ipc_pipe)
tr_err(&ipc_tr, "No pipeline with instance_id = %d", ppl);
tr_err(&ipc_tr, "No pipeline with instance_id = %u", ppl);
else
ppl_data->ppl_id[ppl_data->pipelines_count++] =
ipc_pipe->pipeline->pipeline_id;
Expand Down
Loading