ASoC/soundwire: SOF: keep WoV SoundWire paths active during suspend by bardliao · Pull Request #5968 · thesofproject/linux

bardliao · 2026-10-07T04:35:24Z

Wake-on-voice requires the DSP audio path to remain available while the
system is suspended. Although SOF can keep a D0i3-compatible PCM running,
SoundWire stream and Intel controller suspend handling may still disable
the stream or its bus, while DAPM may power down widgets on the path.
This series propagates the ignore-suspend requirement from SOF to the
SoundWire stream and connected DAPM widgets and keep the required
components alive during system suspend.

Copilot

Copilot review overview

🟡 Changes recommended

Suspend-target handling, DAPM endpoint coverage, and ACE2.x teardown currently prevent safe path retention.

Review effort: Balanced
Findings: 4

Open (4)

Do not retain the bus for stopped D0i3 streams · New
Skip SoundWire teardown on suspend for retained streams · New
Derive D0i3 retention from the actual suspend target · New
Avoid permanently ignoring suspend based only on topology compatibility · New

What changed in this PR

Adds suspend retention for D0i3-compatible SOF SoundWire audio paths.

Changes:

Propagates suspend retention through DAPM and SoundWire streams.
Keeps Intel SoundWire buses active during suspend.
Adjusts trigger handling for retained streams.

File	Description
`sound/soc/sof/pcm.c`	Marks connected DAPM widgets for retention.
`sound/soc/sof/intel/hda.c`	Propagates D0i3 compatibility to SoundWire.
`sound/soc/sof/intel/hda-dai-ops.c`	Handles resume triggers.
`sound/soc/sdw_utils/soc_sdw_utils.c`	Preserves retained streams across suspend.
`include/linux/soundwire/sdw.h`	Adds retention state and bus API.
`drivers/soundwire/stream.c`	Implements bus retention detection.
`drivers/soundwire/intel.c`	Avoids suspending retained controller state.
`drivers/soundwire/intel_auxdevice.c`	Skips bus power transitions when retained.
`drivers/soundwire/intel_ace2x.c`	Applies retention to ACE2.x controllers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

ujfalusi

@bardliao, how about the codec drivers themself? I think that the one you use only marks the regcache cache only, but it would not be far fetched if a codec driver would actually do the right thing and powers down things in their PM suspend callback?

ujfalusi · 2026-10-07T05:24:07Z

 		swidget->spipe->started_count = 0;
 		break;
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+	case SNDRV_PCM_TRIGGER_RESUME:


with this patch: 8d544a0

you are not going to receive the RESUME trigger.

ujfalusi · 2026-10-07T05:26:46Z

+				break;
+		}
+		if (!list_entry_is_head(spcm, &sdev->pcm_list, list) &&
+		    spcm->stream[dir].d0i3_compatible)


this will mark DeepBuffer playback and capture also, which is not correct.

The definition to use is:
9e47005

@ujfalusi Do you mean just test spcm->stream[substream->stream].suspend_ignored?

* WoV streams can be indetified by: * They are capture streams and * They have the d0i3_compatible flag set and * They don't use Deep Buffer

see this in #5951 :
8d544a0

ujfalusi · 2026-10-07T05:29:22Z

 			return ret;
 		}

+		if (spcm->stream[dir].d0i3_compatible) {


this will break deepbuffer playback and capture during suspend, the definition to use is:
9e47005

bardliao · 2026-10-07T06:23:13Z

@bardliao, how about the codec drivers themself? I think that the one you use only marks the regcache cache only, but it would not be far fetched if a codec driver would actually do the right thing and powers down things in their PM suspend callback?

Most SDW codec drivers don't do power down in their suspend callback. IOW the current solution applies to most codecs. We can handle the codecs that need to skip the device suspend in the future if needed.

ujfalusi · 2026-10-07T06:26:59Z

@bardliao, how about the codec drivers themself? I think that the one you use only marks the regcache cache only, but it would not be far fetched if a codec driver would actually do the right thing and powers down things in their PM suspend callback?

Most SDW codec drivers don't do power down in their suspend callback. IOW the current solution applies to most codecs. We can handle the codecs that need to skip the device suspend in the future if needed.

Operation whack-a-mole?

Copilot

Copilot review overview

🟡 Changes recommended

Suspend policy is applied too broadly and required DAPM endpoints are omitted, potentially breaking wake-on-voice and deeper suspend states.

Review effort: Balanced
Findings: 6

Open (6)

Propagate suspend policy only for the active SOF suspend target · New
Mark the starting DAI endpoint before walking connected widgets · New
Avoid permanently ignoring suspend based only on topology compatibility
Derive D0i3 retention from the actual suspend target
Skip SoundWire teardown on suspend for retained streams
Do not retain the bus for stopped D0i3 streams

Copilot

Copilot review overview

🟡 Changes recommended

Suspend-ignore state is incomplete and persists beyond its valid lifecycle, causing both WoV failures and unintended bus retention.

Review effort: Balanced
Findings: 7

Open (7)

Clear or refcount widget suspend-ignore state after resume · New
Mark the starting DAI endpoint before walking connected widgets
Propagate suspend policy only for the active SOF suspend target
Avoid permanently ignoring suspend based only on topology compatibility
Derive D0i3 retention from the actual suspend target
Skip SoundWire teardown on suspend for retained streams
Do not retain the bus for stopped D0i3 streams

Copilot

Copilot review overview

🟡 Changes recommended

Suspend-target mismatches and incomplete DAPM lifecycle handling can disable WoV paths or incorrectly keep inactive buses powered.

Review effort: Balanced
Findings: 2

Open (2)

Include microphone widgets in the WoV ignore-suspend set · New
Clear or refcount widget suspend-ignore state after resume

Resolved since last review (6)

Mark the starting DAI endpoint before walking connected widgets
Propagate suspend policy only for the active SOF suspend target
Avoid permanently ignoring suspend based only on topology compatibility
Derive D0i3 retention from the actual suspend target
Skip SoundWire teardown on suspend for retained streams
Do not retain the bus for stopped D0i3 streams

Copilot

🟡 Changes recommended

Suspend-ignore state is applied too broadly and DAPM endpoint state is not preserved safely.

1 open finding

Preserve pre-existing ignore_suspend state · New

2 resolved since last review

Include microphone widgets in the WoV ignore-suspend set
Clear or refcount widget suspend-ignore state after resume

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

lgirdwood · 2026-10-13T12:33:45Z

@charleskeepax @rfvirgil @simontrimmer fyi - pls do give it a spin if you have time.

Copilot

🟡 Changes recommended

DAPM cache invalidation, exemption cleanup, and shared-widget ownership remain unresolved.

3 open findings

1 resolved since last review

Preserve pre-existing ignore_suspend state

🧠 Review effort: Balanced

 			 * remained enabled in D0ix.
 			 */
 			spcm->stream[substream->stream].suspend_ignored = false;
+			sof_pcm_set_widget_ignore_suspend(sdev, rtd, spcm, substream->stream, false);


Copilot

🟡 Changes recommended

Shared-backend retention flags can become stale as frontend participation changes, disrupting wake-on-voice capture during suspend.

3 open findings

1 resolved since last review

Track shared widget ownership across WoV PCMs

🧠 Review effort: Balanced

Some streams, such as those used for wake-on-voice, must remain active during system suspend. Add an ignore_suspend flag to sdw_stream_runtime and export sdw_bus_ignore_suspend() so bus drivers can check whether any stream on the bus requires it to remain active. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Honor the SoundWire bus ignore-suspend state in the Intel drivers. Preserve the master across system suspend when a stream requires the bus to remain active. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Do not disable a SoundWire stream on suspend when it is marked to remain active. If the stream is already enabled on resume, no further action is needed. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Keep a SoundWire stream active during system suspend when it is used by a WoV stream. WoV streams can be indetified by: They are capture streams and. They have the d0i3_compatible flag set and They don't use Deep Buffer. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

The SOF DSP remains active for wake on voice streams, but DAPM may still power down widgets on the PCM path. Mark the connected endpoint widgets to ignore suspend so DAPM keeps the path powered. Track the widgets whose ignore_suspend flag was set by the PCM in a per-spcm list with a refcount. A widget is only taken over if its ignore_suspend flag was not already set, and the flag is cleared only when its refcount drops to 0. Entries are kept for reuse and freed when the PCM is unloaded. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Multiple front-end streams may share a SoundWire back-end, so a prepare request can arrive after the shared stream is already enabled. Return success without calling sdw_prepare_stream() again in that case. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Copilot

🟡 Changes recommended

Suspend ordering, retained-stream teardown, endpoint cache invalidation, and concurrent activity tracking have unresolved correctness issues.

5 open findings

2 resolved since last review

🧠 Review effort: Balanced

+	case SNDRV_PCM_TRIGGER_START:
+	case SNDRV_PCM_TRIGGER_RESUME:
+	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+		snd_sof_pcm_platform_set_sdw_ignore_suspend(sdev, substream, !ret);


 		ret = sdw_disable_stream(sdw_stream);
 		break;
+	case SNDRV_PCM_TRIGGER_SUSPEND:
+		ret = sdw_stream->ignore_suspend ? 0 : sdw_disable_stream(sdw_stream);


+				fe_active = spcm->stream[dir].suspend_ignored ||
+					other_fe->dpcm[dir].state == SND_SOC_DPCM_STATE_START;


+				dev_dbg(sdev->dev,
+					"WoV PCM %s ignore suspend for widget %s\n",
+					spcm->pcm.caps[dir].name, widget->name);
+				sof_pcm_update_widget_ignore_suspend(sdev, widget, ignore_suspend);


Copilot AI balanced review requested due to automatic review settings October 7, 2026 04:35

bardliao requested review from dbaluta, jack-cy-yu, kv2019i, lgirdwood, lyakh, oder-chiou, plbossart, ranj063, shumingfan and ujfalusi as code owners October 7, 2026 04:35

Copilot started reviewing on behalf of bardliao October 7, 2026 04:35

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread drivers/soundwire/stream.c

Comment thread sound/soc/sof/intel/hda-dai-ops.c Outdated

Comment thread sound/soc/sof/intel/hda.c Outdated

Comment thread sound/soc/sof/pcm.c Outdated

ujfalusi reviewed Oct 7, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 7, 2026 11:12

bardliao force-pushed the sdw-ignore-suspend branch from 0377bcf to d247a69 Compare October 7, 2026 11:12

Copilot started reviewing on behalf of bardliao October 7, 2026 11:12

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread sound/soc/sof/intel/hda.c Outdated

Comment thread sound/soc/sof/pcm.c Outdated

bardliao force-pushed the sdw-ignore-suspend branch from d247a69 to 558587f Compare October 7, 2026 12:04

Copilot AI balanced review requested due to automatic review settings October 7, 2026 12:04

Copilot started reviewing on behalf of bardliao October 7, 2026 12:05

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread sound/soc/sof/pcm.c Outdated

Copilot AI balanced review requested due to automatic review settings October 7, 2026 14:38

bardliao force-pushed the sdw-ignore-suspend branch from 558587f to 9e0e7c2 Compare October 7, 2026 14:38

Copilot started reviewing on behalf of bardliao October 7, 2026 14:38

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread sound/soc/sof/pcm.c Outdated

bardliao force-pushed the sdw-ignore-suspend branch from 9e0e7c2 to 191e953 Compare October 8, 2026 07:54

Copilot AI balanced review requested due to automatic review settings October 8, 2026 07:54

Copilot started reviewing on behalf of bardliao October 8, 2026 07:55

View session

bardliao changed the title ~~ASoC/soundwire: SOF: keep D0i3-compatible SoundWire paths active during suspend~~ ASoC/soundwire: SOF: keep WoV SoundWire paths active during suspend Oct 8, 2026

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Comment thread sound/soc/sof/pcm.c Outdated

lgirdwood previously approved these changes Oct 13, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:10

bardliao dismissed lgirdwood’s stale review via 561350c October 15, 2026 14:10

bardliao force-pushed the sdw-ignore-suspend branch from 191e953 to 561350c Compare October 15, 2026 14:10

bardliao requested a review from singalsu as a code owner October 15, 2026 14:10

Copilot started reviewing on behalf of bardliao October 15, 2026 14:11

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread sound/soc/sof/pcm.c

Comment thread sound/soc/sof/pcm.c Outdated

Comment thread sound/soc/sof/pcm.c

* remained enabled in D0ix.

*/

spcm->stream[substream->stream].suspend_ignored = false;

sof_pcm_set_widget_ignore_suspend(sdev, rtd, spcm, substream->stream, false);

Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:39

bardliao force-pushed the sdw-ignore-suspend branch from 561350c to c17068f Compare October 15, 2026 14:39

Copilot started reviewing on behalf of bardliao October 15, 2026 14:40

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread sound/soc/sof/intel/hda.c Outdated

bardliao added 6 commits October 16, 2026 19:27

soundwire: Intel: preserve buses for ignore-suspend streams

af7c4f3

Honor the SoundWire bus ignore-suspend state in the Intel drivers. Preserve the master across system suspend when a stream requires the bus to remain active. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

ASoC: soc_sdw_utils: preserve streams that ignore suspend

b59fe79

Do not disable a SoundWire stream on suspend when it is marked to remain active. If the stream is already enabled on resume, no further action is needed. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Copilot AI balanced review requested due to automatic review settings October 16, 2026 11:29

bardliao force-pushed the sdw-ignore-suspend branch from c17068f to 1c81692 Compare October 16, 2026 11:29

Copilot started reviewing on behalf of bardliao October 16, 2026 11:29

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

		fe_active = spcm->stream[dir].suspend_ignored \|\|
		other_fe->dpcm[dir].state == SND_SOC_DPCM_STATE_START;

Conversation

bardliao commented Oct 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ujfalusi left a comment

Choose a reason for hiding this comment

Uh oh!

ujfalusi Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

ujfalusi Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

bardliao Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

ujfalusi Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

ujfalusi Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ujfalusi Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

bardliao commented Oct 7, 2026

Uh oh!

ujfalusi commented Oct 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

lgirdwood commented Oct 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Reviewers