Repository navigation
feat(sports): field hockey and tennis standings; months start a new row - #170
Merged
Merged
Conversation
The card kept at most five sports, so an in-season sport past the fifth
was dropped (field hockey this fall). The first five are still picked
as before; any other in-season sport now follows them, and with more
than five each tab takes at least a fifth of the row so the rest are
reached by swiping the tabs sideways or with the arrows.
- Field hockey (Liberty League) shows Sept 14 to Nov 23
- Men's and women's tennis show for the spring season only. The league
names it after the fall before ("2026-27"), so `labelledByFall`
keeps the season check from treating it as last year's table
- Tab scroll arrows sit a little higher, level with the labels
On /sports/all a month's tile followed straight on from the last story of the month before, often mid-row. The tile is now pinned to the first column, so every month begins at the left; a month that doesn't fill its last row leaves the rest of it empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to #168 from e-board feedback.
Standings: field hockey and tennis, scrolling past five sports
The card kept at most five sports, so any in-season sport past the fifth was dropped. Field hockey was cut this fall, even though RPI leads the Liberty League at 6-0.
labelledByFallflag stops the season check from treating it as last year's table.All stories: each month starts a new row
On
/sports/all, a month's tile used to follow straight on from the previous month's last story, often mid-row. It's now pinned to the first column, so every month begins at the left. A month that doesn't fill its last row leaves the rest of it empty.Production impact
No migrations, collection config or deploy changes.
field-hockeyand both tennis values are already in thesportenum.Testing
/sportsshows M. Hockey, W. Hockey, Football, M. Soccer, W. Soccer, then Field Hockey just past the edge. The field hockey table loads with logos./sports/all: month tiles sit in the first column on desktop and phone.pnpm lint(0 errors) andpnpm typecheckpass.