Repository navigation
fix(sports): cap /sports/all pages, admin-only layout delete, parallel standings + schedule - #169
Merged
Merged
Conversation
…tandings and schedule together - /sports/all returns 404 past page 1000 instead of passing a huge offset to Postgres - Sports Layout can only be deleted by admins (it had no delete rule, so any logged-in user could) - /sports fetches standings and the score-strip schedule in parallel; the schedule covers every standings sport and is narrowed to the card's sports afterwards, so a slow feed costs one wait instead of two Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from an audit of the sports section merge (
151e52c..1711904).Changes
/sports/allpage cap. Any?page=above 1000 now returns a 404 before querying. Previously?page=1e20passed an offset past Postgres's bigint range and the request returned a 500.deleterule, so Payload's default let any logged-in user delete it./sports. The schedule used to wait for the standings because the strip follows the standings card's sports.No schema changes and no migrations.
Checks
pnpm typecheck: passespnpm lint: no errors, and no warnings in the changed files🤖 Generated with Claude Code