Repository navigation
fix(database): declare TModel template on where-builder traits - #2322
Open
ondrejmirtes wants to merge 1 commit into
Open
ondrejmirtes wants to merge 1 commit into
ondrejmirtes wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FbAUWcmATbQhrWDPZrVGSg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasWhereRelationMethodsandHasWhereQueryBuilderMethodsuseTModelin their PHPDoc (@return static<TModel>,@var WhereGroupBuilder<TModel>) without declaring it. A trait does not see the template types of the class that uses it, so PHPStan resolvesTModelas the classTempest\Database\Builder\QueryBuilders\TModel. The resulting errors were hidden by theclass.notFoundignore forpackages/database/src/Builder/*.PHPStan 2.3 resolves template types on generic
static<...>return types correctly (phpstan/phpstan-src#6695). Because of that, the unknown class now reaches call sites:Tag::select()->whereHas(...)->all()returnsTModel[], and every property access on the result is reported (28 errors inWhereHasTestandIsDatabaseModelTest).This declares
@template TModelon both traits and passes it through with@use. Theclass.notFoundignore is no longer needed. Keeping it would fail onreportUnmatchedIgnoredErrors, so it's removed. No change in output with PHPStan 2.2.13.🤖 Generated with Claude Code
https://claude.ai/code/session_01FbAUWcmATbQhrWDPZrVGSg