Repository navigation
Conversation
Every class without a registered definition was checked against all dynamic initializers, which were rebuilt after every container reset. In worker mode, this amounted to more than 400 `canInitialize()` calls per request (#2309). The container now remembers which initializer, if any, can initialize a class and tag. This is kept across resets, since it only depends on the registered initializers, and is forgotten when initializers are added or removed. Resolved initializers are now also reused until the container is reset, instead of being autowired every time they're used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Autowiring a class reflected on it from scratch every time: its constructor, parameters, properties, and the `#[Tag]`, `#[Proxy]`, `#[Inject]` and `#[Singleton]` attributes were all looked up and instantiated again. Since class definitions can't change at runtime, this data is now cached once and shared between containers. Resolving an already resolved singleton also no longer reflects on its class. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 1199111 |
brendt
marked this pull request as draft
October 23, 2026 11:54
Remembering initializer lookups added two objects to every container, which made constructing a container slower and increased memory usage, as shown by the register benchmarks. They are now created once they're first needed, or right before the container is cloned so that clones still share them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.