Repository navigation
test: Migrate remaining specs to Swift Testing - #460
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
October 11, 2026 12:51
Generated by 🚫 Danger Swift against 6b1f9d2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the remaining Text, Layout, Table/API, and Document/Generator specs to Swift Testing and remove Quick/Nimble dependencies. No production code changes.
Scope
#if os(macOS) && swift(>=6.2). Keepswift-tools-versionat 6.1.Verification
Focused directory checks passed. The latest full macOS run passed 229 unit tests and 6 integration tests.
make lintandgit diff --checkpassed. The testing flag is restored to disabled. Other platforms were not tested locally.Unresolved conversion regression
Earlier combined focused runs exposed inconsistent font/default-style expectations that passed in isolation. The latest full run passed, but the cause is unresolved. This is a snapshot draft, not a claim that conversion parity is fully verified.