Skip to content

test: Migrate remaining specs to Swift Testing - #460

Merged
philprime merged 1 commit into
mainfrom
philprime/test/swift-testing-remaining
Oct 11, 2026
Merged

philprime merged 1 commit into
mainfrom
philprime/test/swift-testing-remaining

Conversation

@philprime

Copy link
Copy Markdown
Member

Migrate the remaining Text, Layout, Table/API, and Document/Generator specs to Swift Testing and remove Quick/Nimble dependencies. No production code changes.

Scope

  • Replace legacy specs with named, parameterized tests and Arrange/Act/Assert sections. Remove the commented-out debug spec and assertion-free placeholders.
  • Preserve embedded image bytes as package resources, reusing the existing JPEG fixture and adding the table-content PNG.
  • Use native macOS exit tests for unsupported text subclasses and invalid table content, guarded by #if os(macOS) && swift(>=6.2). Keep swift-tools-version at 6.1.
  • Check validation error cases and associated messages explicitly, correcting the legacy column-width expectation that Nimble compared only by error domain/code.

Verification
Focused directory checks passed. The latest full macOS run passed 229 unit tests and 6 integration tests. make lint and git diff --check passed. The testing flag is restored to disabled. Other platforms were not tested locally.

Unresolved conversion regression
Earlier combined focused runs exposed inconsistent font/default-style expectations that passed in isolation. The latest full run passed, but the cause is unresolved. This is a snapshot draft, not a claim that conversion parity is fully verified.

@philprime
philprime marked this pull request as ready for review October 11, 2026 12:51
@github-actions

Copy link
Copy Markdown
Warnings
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The Package.swift was updated, but there were no changes in TPPDF.podspec, Package.resolved. Did you forget to update them?

Generated by 🚫 Danger Swift against 6b1f9d2

@philprime
philprime enabled auto-merge (squash) October 11, 2026 12:58
@philprime
philprime merged commit db4b58d into main Oct 11, 2026
10 checks passed
@philprime
philprime deleted the philprime/test/swift-testing-remaining branch October 11, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant