Repository navigation
test(table): Migrate internal layout specs to Swift Testing - #458
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
October 10, 2026 21:28
philprime
enabled auto-merge (squash)
October 10, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate internal table layout and merging specs to Swift Testing using Arrange-Act-Assert. Preserve both header-repetition variants, every per-cell frame expectation, outline/page-break positions, and all three merge/span scenarios.
Keep the original UIKit platform guard and Catalyst-specific layout values. Existing Swift Testing pagination regressions remain untouched.
Verification
Focused tests,
make test-macos,make lint, andgit diff --checkpassed. The testing flag was restored. The original UIKit-only XCTest layout cases and their migrated equivalents also passed focused Mac Catalyst checks. Other platforms were not tested locally. macOS runs still emit CoreData/account-store diagnostics without test failures.Scope
Independent PR based directly on main after the first migration batch merged. No production, dependency, or package changes. Quick/Nimble remain available for directories not yet migrated.