Repository navigation
test(image): Migrate specs to Swift Testing - #454
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
October 10, 2026 10:48
philprime
enabled auto-merge (squash)
October 10, 2026 10:48
Generated by 🚫 Danger Swift against 44ce1c8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the three legacy image specs to Swift Testing using Arrange-Act-Assert and descriptive scenarios. Preserve initializer/default and equality coverage, and exercise each fitting mode through PDFImage initialization.
Replace the duplicated embedded JPEG strings with the same bytes in an SPM test resource. Existing image-pagination regressions and production code remain unchanged.
Verification
Focused tests,
make test-macos,make lint, andgit diff --checkpassed. The testing flag was restored. macOS only was tested locally. CoreData NSXPCConnection diagnostics remain present in both baseline and migrated full runs, without test failures.Scope
Independent migration based directly on
main, with no dependency on the other migration PRs. Quick/Nimble dependency removal is deferred until the whole suite has migrated.