fix(ci): satisfy Rust 1.99 clippy lints - #347
Merged
StefanSteiner merged 1 commit intoOct 5, 2026
Merged
Conversation
CI tracks the moving stable toolchain, and 1.99 added/tightened lints that fail the -D warnings clippy gate: - must_use_candidate on six accessor methods in hyperdb-api - assert_is_empty on assert!(x.is_empty()) in tests (use assert_eq!/assert_ne!) - unfulfilled #[expect(clippy::float_cmp)] in hyperdb-api-core tests, which 1.99 no longer triggers No behaviour change.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI runs the moving
stabletoolchain. Rust 1.99.0 (2026-09-28) added/tightened clippy lints, so theclippyjob fails under-D warningson every PR (first seen on #346, unrelated to it).clippy::must_use_candidate: add#[must_use]to six accessors inhyperdb-api(Inserter::table_definition,names.rsname/schema/table,grpc_connection.rsconfigx2).clippy::assert_is_empty: replaceassert!(x.is_empty())/assert!(!x.is_empty())in tests withassert_eq!/assert_ne!(clippy's own suggestions, pluslen()forms where the element type is ambiguous).#[expect(clippy::float_cmp)]inhyperdb-api-coretests that 1.99 no longer triggers (unfulfilled expectations are errors).No behaviour change; test/lint code and attributes only.
Test plan
cargo +1.99.0 clippy --workspace --all-targets --all-features -- -D warnings— clean (exit 0)cargo +1.99.0 fmt --allclippy(ubuntu, windows) andtestgreenNote: on 1.98 the new
#[must_use]attributes tripdouble_must_use(those return types are already#[must_use]); CI is on 1.99 so this is only visible on older local toolchains.