Repository navigation
Fix DivisionByZeroError in CodeCloneMap::averageSize() when no clones found - #5
Merged
dimadeush merged 1 commit intoOct 27, 2026
Conversation
apphp
force-pushed
the
fix/average-size-division-by-zero
branch
from
October 27, 2026 20:43
419872f to
21330dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DivisionByZeroError in CodeCloneMap::averageSize()
averageSize() divided the number of duplicated lines by the clone count without checking for zero. When no clones were found, Log\Json called it from writeHeader() and the run crashed with DivisionByZeroError. The text logger was unaffected because it checks isEmpty() first.
averageSize() now returns 0.0 when there are no clones, so every logger is covered. In the JSON report this gives "averageCloneSize": 0.