This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Repository navigation
chore(clover): add smoke test instructions for robots to test gcp - #8291
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
sprutton1
force-pushed
the
feat/clover/gcp/smoke
branch
from
January 16, 2026 16:39
c402d8b to
f7ae224
Compare
|
Working with Module Index at: https://module-index.systeminit.com AWS - 0 new, 1 changed asset(s)Google - 0 new, 1936 changed asset(s) |
1 similar comment
|
Working with Module Index at: https://module-index.systeminit.com AWS - 0 new, 1 changed asset(s)Google - 0 new, 1936 changed asset(s) |
sprutton1
force-pushed
the
feat/clover/gcp/smoke
branch
from
January 16, 2026 17:00
f7ae224 to
a4fb332
Compare
sprutton1
marked this pull request as ready for review
January 16, 2026 17:00
|
Working with Module Index at: https://module-index.systeminit.com AWS - 0 new, 1 changed asset(s)Google - 0 new, 1936 changed asset(s) |
sprutton1
force-pushed
the
feat/clover/gcp/smoke
branch
from
January 16, 2026 17:14
a4fb332 to
57cddd4
Compare
|
Working with Module Index at: https://module-index.systeminit.com AWS - 0 new, 1 changed asset(s)Google - 0 new, 1936 changed asset(s) |
Contributor
aaron-dernley
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

How does this PR change the system?
Adds a smoke.md doc for gcp to tell the robots how to test clover changes there. It's slower than I would like, but it works when they actually follow the instructions. To be frank, they seem to skip steps when they feel like it. There were a lot of small correctness changes that came out of this, mostly minor shape things.
Screenshots:
How was it tested?
This is a test. How 'bout that
Does it require a docs change?
In short: 🔗