Skip to content

fix: keep network statistics honest during partial outages - #58

Merged
sidhujag merged 1 commit into
masterfrom
codex/stats-availability
Oct 21, 2026
Merged

sidhujag merged 1 commit into
masterfrom
codex/stats-availability

Conversation

@sidhujag

Copy link
Copy Markdown
Member

Summary

  • Keep node history and live statistics independent; a failed statistics request no longer hides valid history.
  • Distinguish missing, stale and unverified observations from genuine zero values. Preserve usable market quotes and on-chain statistics independently, without displaying Infinity or fabricated zero balances.
  • Apply the same availability semantics to governance support, budgets and proposal timing; reject explicitly stale superblock anchors before preparation while preserving legacy-server compatibility.
  • Prevent intrinsic chart widths from overflowing 320-pixel layouts and add the dashboard cases to the existing browser CI invocation without removing recovery coverage.

Paired backend fix: syscoin/sysnode-backend#44. Deploy this compatibility-safe frontend first, then the independently reviewed backend snapshot change.

Validation

  • Full unit suite: 68 suites / 1,127 tests passed, natural exit.
  • Production build passed.
  • Combined browser run: 9/9 cases passed, including seven controlled-API dashboard/governance cases and the two existing recovery cases at 320/390-pixel widths.
  • Read-only compatibility check against the current live legacy response preserved 2,139 enabled / 3,123 registered nodes and its 5.20% ROI, marked freshness-unverified because the legacy response has no source timestamps.
  • Independent source review of availability, malformed payloads, stale-anchor handling and all affected consumers completed without outstanding findings; final immutable-head reviews and CI remain required before deployment.

These browser checks use controlled API fixtures. They are not a public-chain recovery lifecycle test. No signing, transaction broadcast, fee policy or voting authorization changes are included.

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T23:09:13.370782Z a825f52 Manual request
🔒 Security Review ✅ Completed 2026-10-21T23:11:15.326877Z a825f52 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: a825f52f23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag
sidhujag merged commit 3c54bcd into master Oct 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant