Skip to content

Add smart-account recovery email alert enrollment - #57

Merged
sidhujag merged 5 commits into
masterfrom
codex/recovery-email-alerts
Oct 21, 2026
Merged

sidhujag merged 5 commits into
masterfrom
codex/recovery-email-alerts

Conversation

@sidhujag

Copy link
Copy Markdown
Member

Summary

  • Add a recovery-only Account panel with wallet-signed enrollment, monitoring health and exact recovery deadlines. Keys and cancellation authority remain in the wallet.
  • Protect unsubscribe with password and TOTP, invalidate account/network changes during signing, and prevent stale refreshes from restoring a disabled subscription in the UI.
  • Keep 320px layouts readable, add production-browser regressions to CI, and update follow-redirects to the official 1.16.1 security release with credential-stripping regressions.

Validation

  • Clean npm ci and production build passed.
  • Full Jest: 65 suites, 1065 tests passed.
  • Runtime/deployment checks: 10 passed, including cross-origin credential stripping for array and metacharacter headers.
  • Production browser: 320px enrollment and 360px pending-recovery/unsubscribe flows passed.
  • Production npm audit: 0 vulnerabilities.

Paired with the Sysnode backend recovery-alert endpoints. Browser tests use synthetic wallet and chain fixtures; they are not a public-chain end-to-end test. No release or deployment is performed by this PR.

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T21:54:08.608808Z fb22c01 Manual request
🔒 Security Review ✅ Completed 2026-10-21T21:17:19.377725Z f1e4527 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1e4527983

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +364 to +365
if (!mounted.current || userRef.current !== id) return;
setRemoving(null);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove disabled subscriptions from local state before refreshing

If the DELETE succeeds but either request in the subsequent load() fails, the disabled subscription remains in subscriptions: load() preserves the previous list on errors, and this success path only clears the confirmation form. The card can consequently continue displaying “Monitoring active” for an account that no longer receives alerts, while isLinked also prevents re-enabling it until a refresh succeeds. Filter the confirmed-deleted subscription out of local state immediately after DELETE succeeds, independently of the follow-up refresh.

Useful? React with 👍 / 👎.

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 9a2daf0f33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 0e20052fd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 0e20052fd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: fb22c0116f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: fb22c0116f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag
sidhujag merged commit 679394d into master Oct 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant