Repository navigation
Keep requested privacy pools current with public withdrawal data - #48
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested privacy pools now continue syncing after the first request and resume after a backend restart. Public snapshots include the pool-wide withdrawn-nullifier list so Pali can match notes locally without making note-specific RPC requests. Unrequested pools remain inactive.
The index keeps one bounded queue, the existing 5,000-block range cap and 45-second job budget. Every nested RPC request checks shutdown and the job deadline. Sparse successful ranges can recover toward the existing cap after a provider forces smaller ranges. Old deposit-only checkpoints are rebuilt; failed refreshes preserve the last complete snapshot.
Validation: 1,524 tests across 75 suites, 12 codec tests, and production dependency audit passed. Independent review reproduced and verified the nested-request cancellation fix; its focused rerun passed 52 tests. A read-only MEVBlocker probe returned 956 deposits and 775 withdrawals for one historical 100-block range; this is not full-history provider qualification.
The service remains disabled by default. A reconstructed deposit root authenticates deposit inclusion, not completeness of the withdrawal feed. Snapshots describe their finalized block and do not cover later or pending withdrawals. No note material, balances, proofs, or broadcasts enter this service.