Repository navigation
Fix compressed JSON parsing and validation dependency advisories - #47
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production dependency audit currently blocks deployment because both JSON-parser paths and Zod resolve to vulnerable versions. Pin body-parser to 2.4.0 and Zod to 4.6.7, and refresh Express's compatible nested body-parser to 1.20.9. Express stays on 4.22.1; there is no framework-major upgrade or application/database change.
The parser updates fix the unauthenticated compressed-body crash described in GHSA-27r3-jxmh-p828. Zod includes the constrained-collection validation fix in GHSA-mrhx-c7xc-m3w5. The added regressions send bounded gzip/deflate trailing-byte payloads through the real auth router with both the production parser composition and standalone app parser, then verify the process still handles a new request. Subprocess isolation prevents a future regression from crashing the test runner. A small Zod case verifies size rejection precedes element validation.
Validation on Node 22.23.4:
npm cipassed using npm 10.npm audit --omit=dev --audit-level=highpassed: 0 high, 0 critical; 4 low and 5 moderate findings remain outside this focused patch.git diff --checkpassed.The audit threshold, deployment workflow, and snapshot-feature PR are unchanged. No deployment has been performed.