Repository navigation
Validate PSBT fee inputs and update Bitcoin dependencies - #17
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Syscoin PSBT fee override must validate the current previous-output metadata when calculating fees. This change checks non-witness transaction identity and output, rejects inconsistent metadata, and recalculates cached fees while preserving allocation burns and unsigned previews. Witness-only metadata still requires a trusted previous-output source from the caller.
Updates bitcoinjs-lib and bip39 to patched versions and adds CI for Node 24 and 26.
Validation: 636 offline unit tests and Standard lint passed. Additional synthetic Pali, Sysnode, Ledger and Trezor compatibility tests passed using mocked devices and RPC; no public transactions or physical hardware were used.