Repository navigation
fix: update Lightning dependencies for security fixes - #123
Conversation
|
@piotr-iohk I'm taking the release prep on this branch: version files for |
Partial validationRan locally on a0ea0a3, with locked dependencies. The PR still points to this revision.
Integration validation is not fully green:
The same reorg seed/input and assertion also fail on #124 at 67929be and on rc.66 source using the pre-security dependency graph (Lightning 0.2.5, liquidity 0.2.3, transaction-sync 0.2.1). The splice error was also previously reproduced with that pre-security graph. These comparisons point to existing failures under the controlled baseline; no new regression from the three security dependency bumps is established. The control does not reconstruct the original published rc.66 binary's dependencies. For clarity, #124's earlier randomized reorg run passed, but replaying this newly discovered seed fails. The earlier pass remains valid for the cases it sampled; it does not cover this input. Environment: macOS arm64, Rust/Cargo 1.90.0, isolated Bitcoin 27.2 and electrs No independent vulnerability reproduction or Android/iOS build/device testing was performed. This is partial validation, not full integration sign-off or shipping approval. The shared splice and reorg failures still need investigation. Prepared log archive: |
|
Release prep for
|
There was a problem hiding this comment.
Verdict: ✅ Approve
Review: diff 7 files.
Findings:
N/A
Proven at d1bd9fc:
- The xcframework slices and Android
.sofiles built from this tree embedlightning,lightning-liquidityandlightning-transaction-sync0.2.7 and no older version. - The
Package.swiftchecksum matches the builtLDKNodeFFI.xcframework.zip. - On Linux at d1bd9fc, these pass: the lib tests, the 45
integration_tests_rusttests outside the channel cycles and the splice, and 108 of the 110multi_address_types_tests. The other two (channel_fundingtests) hung under parallel load and pass when run alone.
Not proven:
reorg_testfails attests/reorg_test.rs:196(spendable_onchain_balance_sats). @piotr-iohk reproduced the same failure on rc.66 with 0.2.5, so this predates the PR.channel_full_cycle*andsplice_channelstall at splice funding signing on rc.71 and rc.66 alike, so this predates the PR and is tracked separately.- The uploaded release zip and the Android package
publish-android.ymlbuilds from the tag: check the zip's checksum and the AAR's crate versions after publishing.
Reviewed by claude-opus-5-5 via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest
Release |
|
Correction to the
The verdict stands. |
Update
lightning,lightning-liquidityandlightning-transaction-syncto 0.2.7 for the upstream security fixes, including malicious-counterparty commitment signing and inbound-channel Electrum sync denial of service. The lockfile changes only these three package versions. This PR uses Talos’s existing branch ata0ea0a3.Intended release path: a new node release, proposed
0.7.0-rc.72, for Android/iOS master and Bitkit 2.6.0. The version bump, regenerated native artifacts and release are not part of this draft yet. The apps currently pin rc.71.Validation
Talos reports
cargo test --lib --locked: 117 passed, andcargo check --locked --features uniffi: passed with existing warnings. These results are attributed to his report; the PR creator has not independently rerun them. Integration tests, binding generation and downstream app tests remain outstanding. No independent vulnerability reproduction is claimed.Before release
The proposed separate rc.66-based security hotfix for Bitkit 2.5.1 is discussed in the release-plan thread. This draft does not approve either release path.
Companion hotfix draft: #124, based on the shipped rc.66 source.