Repository navigation
chore: update paykit to rc77 - #1500
Conversation
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryUpdates Paykit from
Reviews (1) · Last reviewed commit: "chore: update paykit to rc77" · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Bumps paykit-android from 0.1.0-rc76 to 0.1.0-rc77 and adds a changelog fragment. Reviewed 82c6350, full tier (dependency manifest), reasoned from the code and CI; the branch was not built locally.
What I checked, and 2 candidates I ruled out
Upstream diff read: pubky/paykit-rs v0.1.0-rc76..v0.1.0-rc77 (tag at 1d2ca71, on master): pubky_session.rs (new decode_pubky_uri), runtime/mod.rs (fetch_public_file_uri), runtime/profiles.rs (directory listing, blob delete), domain/contacts/blobs.rs, the error-redaction changes in paykit-lib. No paykit-ffi/src change, so the generated Kotlin surface is the same as rc76, consistent with the PR body.
App call sites traced: PaykitSdkService.fetchFile / fetchPublicFile / listPublicDirectoryPage, reached from PubkyImageFetcher (avatars) and ShopContactImporter (marker listing and shop.json fetch).
CI: build, lint, detekt green; build-local (e2e) still pending at time of review.
Ruled out
- Double decoding of app-built URIs: rc77 now percent-decodes every input before
PubkyResourcere-encodes it. The only behaviour change is for paths containing%; the app's constructed URIs (pubky://$seller/pub/pubky.app/marketplace/v1/shop.json, the marker root) contain none, and listed URIs are passed back unchanged, which is the convention rc77 documents. ShopContactImporter.verifiedSellerstring comparison: it compares a listed URI with"$root$seller.json"; the seller is a z-base-32 key and the root has no encodable characters, so the canonical encoding cannot make them differ.
Merge confidence: 4/5, a native dependency bump whose new URI handling has no app-side test; the e2e job was still running.
There was a problem hiding this comment.
Suggestion: 👍 Approve
Review: diff 2 files.
synonymdev/bitkit-ios#934 pins Paykit RC77 at 67bae1f too. Its wider Shop-contact changes match those in merged #1485.
QA:
Tests queued.
Reviewed by gpt-6.1-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest
Closes #1501
This PR updates Bitkit to published Paykit RC77 after #1485 merged.
Description
The SDK source is merged in pubky/paykit-rs#194. Generated APIs are unchanged from RC76. No app logic, polling, payment approval, storage migration or safety wait changes.
Design
N/A - no UI changes.
Preview
N/A
QA Notes
Journeys
N/A - not drivable; see Manual Tests. These URI and error fixtures are not supplied by the standard journey environment.
Manual Tests
Automated Checks
testDevDebugUnitTest --rerun-tasks --no-daemon --max-workers=2 --warning-mode allagainst the downloaded RC77 Maven artifact: 4,239 tests passed, with no failures or skips. The same-source RC76 baseline also passed 4,239 tests.262b169735: all 1,401 Detekt findings and compiler/deprecation diagnostics are unchanged; no introduced findings. Compilation and APK assembly passed.No tests were added or removed. No current-head device or checkout pass is claimed. Existing Shop-contact acceptance checks from #1485 are not completed by this dependency bump. Matching iOS update: synonymdev/bitkit-ios#934.