Repository navigation
chore: bump version 2.5.1 - #1472
piotr-iohk wants to merge 3 commits into
Conversation
|
2.5.1 release preparation is finalized for validation at Dispatched checks on this exact revision:
Both E2E workflows successfully resolved |
|
@piotr-iohk conflicts |
|
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Hotfix 2.5.1 off v2.5.0: versionCode 190 to 191, versionName 2.5.1, LDK Node 0.7.0-rc.66 to 0.7.0-rc.66.1, dated changelog. Reviewed b48392b, full tier (dependency manifest), reasoned from the code and CI, branch not built here.
What I checked, and 3 candidates I ruled out
Read: app/build.gradle.kts version block, gradle/libs.versions.toml, settings.gradle.kts repositories, CHANGELOG.md
CI on the head: CI (build-local, build-staging, build-release) and E2E green, including lightning_security, send, lnurl_transfer and the staging suites. The ovi-reviewer check sits at action_required, not tied to this diff.
Ruled out
- versionCode collision: master is still at 190, so 191 is a fresh code for this branch; a later master bump needs to skip past it, which is a release-process step, not a defect here.
- Artifact not published:
com.synonym:ldk-node-androidresolves from the ldk-node GitHub Packages repo already listed insettings.gradle.kts, and build-release resolved0.7.0-rc.66.1green. - Tag drift:
v2.5.1already points atb48392b, this head.
Merge confidence: 5/5, CI and E2E green on the head and the change is a version and dependency pin a build exercises.
ovitrif
left a comment
There was a problem hiding this comment.
Verdict: ♻️ Comment
Review: diff 3 files.
Comment only, so this PR cannot be merged by accident: it is to be closed after the 2.5.1 store release, never merged into master. The LDK update reaches master through #1475.
Findings:
N/A
release-2.5.1differs fromv2.5.0only inversionCode191,versionName2.5.1,ldk-node-android0.7.0-rc.66.1and the dated 2.5.1 changelog.0.7.0-rc.66.1is the rc.66 source with onlylightning,lightning-liquidityandlightning-transaction-syncat 0.2.7, and its published Android libraries embed those versions.
Reviewed by claude-opus-5-5 via gh-pr-review-loop skill
Prepare Bitkit 2.5.1 (build 191) from
v2.5.0with LDK Node0.7.0-rc.66.1for upstream Lightning security fixes.Description
Design
N/A — no UI changes.
Preview
N/A
QA Notes
Journeys
Existing Lightning payment and wallet recovery journeys apply.
Manual Tests
Release runtime validation remains pending.
Automated Checks
Version metadata and changelog structure verified; diff whitespace checks passed. Branch-dispatched CI and regular E2E will be linked in a follow-up comment. E2E uses
release-2.5.1in the test repo, initially identical to tag2.5.0. Migration is deferred.