Skip to content

chore: bump version 2.5.1 - #1472

Closed
piotr-iohk wants to merge 3 commits into
masterfrom
release-2.5.1
Closed

piotr-iohk wants to merge 3 commits into
masterfrom
release-2.5.1

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Prepare Bitkit 2.5.1 (build 191) from v2.5.0 with LDK Node 0.7.0-rc.66.1 for upstream Lightning security fixes.

Description

  • Set version 2.5.1 and build 191.
  • Update LDK Node from rc.66 to rc.66.1.
  • Finalize the dated 2.5.1 changelog and comparison links.
  • Keep this hotfix based on v2.5.0. Close this PR after the store release; do not merge it into master. The equivalent LDK security update reaches master and 2.6.0 separately through rc.72. Preserve the release branch and v2.5.1 tag as the shipped hotfix history.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Journeys

Existing Lightning payment and wallet recovery journeys apply.

Manual Tests

Release runtime validation remains pending.

Automated Checks

Version metadata and changelog structure verified; diff whitespace checks passed. Branch-dispatched CI and regular E2E will be linked in a follow-up comment. E2E uses release-2.5.1 in the test repo, initially identical to tag 2.5.0. Migration is deferred.

@piotr-iohk

Copy link
Copy Markdown
Collaborator Author

2.5.1 release preparation is finalized for validation at b48392bd89b67ce3ae177ab6e00fa50de95516ee (tag v2.5.1): dated changelog, comparison links, draft GitHub release and translated local store notes are prepared. LDK Node is 0.7.0-rc.66.1.

Dispatched checks on this exact revision:

Both E2E workflows successfully resolved e2e_branch=release-2.5.1. The E2E branch points to 2856050ef62493a187e506970a3f88f611db8803, exactly tag 2.5.0. These are branch-dispatched checks, avoiding the conflicting merge into master. Migration has not been dispatched. Results are pending; this is not release sign-off.

@piotr-iohk
piotr-iohk marked this pull request as ready for review October 13, 2026 15:19
@piotr-iohk
piotr-iohk requested a review from ovitrif October 13, 2026 15:19
@ovi-reviewer

ovi-reviewer Bot commented Oct 13, 2026

Copy link
Copy Markdown

@piotr-iohk conflicts

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] No code issues were found that block the hotfix release; the stated plan is to close this PR without merging into master.

Summary

Prepares Bitkit 2.5.1, build 191, as a hotfix from v2.5.0.

  • Bitkit ships version 2.5.1 with an updated Lightning library.

Reviews (1) · Last reviewed commit: "chore: finalize 2.5.1 release changelog" · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Hotfix 2.5.1 off v2.5.0: versionCode 190 to 191, versionName 2.5.1, LDK Node 0.7.0-rc.66 to 0.7.0-rc.66.1, dated changelog. Reviewed b48392b, full tier (dependency manifest), reasoned from the code and CI, branch not built here.

What I checked, and 3 candidates I ruled out

Read: app/build.gradle.kts version block, gradle/libs.versions.toml, settings.gradle.kts repositories, CHANGELOG.md
CI on the head: CI (build-local, build-staging, build-release) and E2E green, including lightning_security, send, lnurl_transfer and the staging suites. The ovi-reviewer check sits at action_required, not tied to this diff.

Ruled out

  • versionCode collision: master is still at 190, so 191 is a fresh code for this branch; a later master bump needs to skip past it, which is a release-process step, not a defect here.
  • Artifact not published: com.synonym:ldk-node-android resolves from the ldk-node GitHub Packages repo already listed in settings.gradle.kts, and build-release resolved 0.7.0-rc.66.1 green.
  • Tag drift: v2.5.1 already points at b48392b, this head.

Merge confidence: 5/5, CI and E2E green on the head and the change is a version and dependency pin a build exercises.

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ♻️ Comment

Review: diff 3 files.

Comment only, so this PR cannot be merged by accident: it is to be closed after the 2.5.1 store release, never merged into master. The LDK update reaches master through #1475.

Findings:
N/A

  • release-2.5.1 differs from v2.5.0 only in versionCode 191, versionName 2.5.1, ldk-node-android 0.7.0-rc.66.1 and the dated 2.5.1 changelog.
  • 0.7.0-rc.66.1 is the rc.66 source with only lightning, lightning-liquidity and lightning-transaction-sync at 0.2.7, and its published Android libraries embed those versions.

Reviewed by claude-opus-5-5 via gh-pr-review-loop skill

@piotr-iohk piotr-iohk closed this Oct 14, 2026

This branch was successfully deployed

1 active deployment
release — b48392bd Deployed Oct 13, 2026 by piotr-iohk via build-release #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants