Repository navigation
[symfony] Skip data holders with public properties in "NoNullableServiceInConstructorRule" - #335
Merged
TomasVotruba merged 1 commit intoOct 2, 2026
Conversation
…iceInConstructorRule" A service does not expose its dependencies as public properties, so a class with public instance properties (own, promoted or inherited) holds data, and its nullable constructor parameters are optional values. This covers value objects outside the skipped namespace list, for example in a "Model" namespace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoNullableServiceInConstructorRuleskips data holders only by namespace (\Entity\,\DTO\,\Dto\,\ValueObject\, …). Value objects in other namespaces are reported, for example a domain model that holds optional data:A service does not expose its dependencies as public properties. So a class with public instance properties holds data, and its nullable constructor parameters are optional values. This PR skips such classes. Own, promoted and inherited public properties count, so a child class that passes values to a data-holder parent is skipped too. Static properties do not count.
The existing
ReportNullableServicefixture (private promoted services) is still reported. 2 new fixtures cover a promoted public property and a child of a public-property parent; both were reported before the change. The full suite, ECS, PHPStan and Rector pass.