Skip to content

fix: fire-forget domain version update #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petruki merged 1 commit into from
Oct 6, 2026
Merged

fix: fire-forget domain version update #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/services/config-strategy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export async function createStrategy(args, admin, status = true) {
RouterTypes.STRATEGY, false, environment.name);

await configStrategy.save();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

return configStrategy;
}
Expand All @@ -81,7 +81,7 @@ export async function deleteStrategy(id, admin) {
RouterTypes.STRATEGY, false, configStrategy.activated.keys().next().value);

await configStrategy.deleteOne();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

// resets permission cache
permissionCache.permissionReset(configStrategy.domain, ActionTypes.ALL, RouterTypes.STRATEGY, configStrategy.name);
Expand All @@ -98,7 +98,7 @@ export async function updateStrategy(id, args, admin) {
const updates = Object.keys(args);
updates.forEach((update) => configStrategy[update] = args[update]);
await configStrategy.save();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

return configStrategy;
}
Expand All @@ -120,7 +120,7 @@ export async function addVal(id, args, admin) {

configStrategy.values.push(value);
await configStrategy.save();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

return configStrategy;
}
Expand Down Expand Up @@ -154,7 +154,7 @@ export async function updateVal(id, args, admin) {
configStrategy.values.splice(indexOldValue, 1);
configStrategy.values.push(newvalue);
await configStrategy.save();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

return configStrategy;
}
Expand All @@ -175,7 +175,7 @@ export async function removeVal(id, args, admin) {

configStrategy.values.splice(indexValue, 1);
await configStrategy.save();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

return configStrategy;
}
Expand All @@ -199,7 +199,7 @@ export async function updateStatusEnv(id, args, admin) {

configStrategy.activated.set(updates[0], args[updates[0]]);
await configStrategy.save();
await updateDomainVersion(configStrategy.domain);
void updateDomainVersion(configStrategy.domain);

return configStrategy;
}
20 changes: 10 additions & 10 deletions src/services/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export async function createConfig(args, admin) {

// creates config
await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

// resets permission cache
permissionCache.permissionReset(config.domain, ActionTypes.ALL, RouterTypes.CONFIG, config.group);
Expand All @@ -139,7 +139,7 @@ export async function deleteConfig(id, admin) {
config = await verifyOwnership(admin, config, config.domain, ActionTypes.DELETE, RouterTypes.CONFIG);

await config.deleteOne();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

// resets permission cache
permissionCache.permissionReset(config.domain, ActionTypes.ALL, RouterTypes.CONFIG, config.group);
Expand Down Expand Up @@ -174,7 +174,7 @@ export async function updateConfig(id, args, admin) {
updates.forEach((update) => config[update] = args[update]);

await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

return config;
}
Expand Down Expand Up @@ -228,7 +228,7 @@ export async function updateConfigRelay(id, args, admin) {
}

await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

return config;
}
Expand All @@ -243,7 +243,7 @@ export async function updateConfigStatus(id, args, admin) {

updates.forEach((update) => config.activated.set(update, args[update]));
await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

return config;
}
Expand All @@ -254,7 +254,7 @@ export async function removeConfigStatusEnv(id, env, admin) {
RouterTypes.CONFIG, false, env);
config.updatedBy = admin.email;

await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);
return removeConfigStatus(config, env);
}

Expand Down Expand Up @@ -291,7 +291,7 @@ export async function addComponent(id, args, admin) {
config.updatedBy = admin.email;
config.components.push(component._id);
await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

return config;
}
Expand All @@ -304,7 +304,7 @@ export async function removeComponent(id, args, admin) {
const indexComponent = config.components.indexOf(args.component);
config.components.splice(indexComponent, 1);
await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

return config;
}
Expand All @@ -320,7 +320,7 @@ export async function updateComponent(id, args, admin) {
config.updatedBy = admin.email;
config.components = args.components;
await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);

return config;
}
Expand All @@ -342,7 +342,7 @@ export async function removeRelay(id, env, admin) {
}

await config.save();
await updateDomainVersion(config.domain);
void updateDomainVersion(config.domain);
}

return config;
Expand Down
10 changes: 5 additions & 5 deletions src/services/group-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export async function createGroup(args, admin) {
groupconfig = await verifyOwnership(admin, groupconfig, domain._id, ActionTypes.CREATE, RouterTypes.GROUP);

// creates group config
await updateDomainVersion(domain._id);
void updateDomainVersion(domain._id);
await groupconfig.save();

// resets permission cache
Expand All @@ -83,7 +83,7 @@ export async function deleteGroup(id, admin) {
groupconfig = await verifyOwnership(admin, groupconfig, groupconfig.domain, ActionTypes.DELETE, RouterTypes.GROUP);

await groupconfig.deleteOne();
await updateDomainVersion(groupconfig.domain);
void updateDomainVersion(groupconfig.domain);

// resets permission cache
permissionCache.permissionReset(groupconfig.domain, ActionTypes.ALL, RouterTypes.GROUP);
Expand Down Expand Up @@ -114,7 +114,7 @@ export async function updateGroup(id, args, admin) {
updates.forEach((update) => groupconfig[update] = args[update]);
groupconfig.name = formatInput(groupconfig.name, { allowSpace: true });
await groupconfig.save();
await updateDomainVersion(groupconfig.domain);
void updateDomainVersion(groupconfig.domain);

return groupconfig;
}
Expand All @@ -129,7 +129,7 @@ export async function updateGroupStatusEnv(id, args, admin) {
const updates = await checkEnvironmentStatusChange(args, groupconfig.domain);
updates.forEach((update) => groupconfig.activated.set(update, args[update]));
await groupconfig.save();
await updateDomainVersion(groupconfig.domain);
void updateDomainVersion(groupconfig.domain);

return groupconfig;
}
Expand All @@ -140,7 +140,7 @@ export async function removeGroupStatusEnv(id, env, admin) {
groupconfig = await verifyOwnership(admin, groupconfig, groupconfig.domain, [ActionTypes.UPDATE, ActionTypes.UPDATE_ENV_STATUS],
RouterTypes.GROUP, false, env);
groupconfig.updatedBy = admin.email;
await updateDomainVersion(groupconfig.domain);
void updateDomainVersion(groupconfig.domain);
return removeGroupStatus(groupconfig, env);
}

Expand Down
2 changes: 1 addition & 1 deletion src/services/slack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,5 +300,5 @@ async function approveChange(domain, ticket) {
await group.save();
}

await updateDomainVersion(domain);
void updateDomainVersion(domain);
}
Loading