Repository navigation
fix(server): wake idle workers on admitted work - #807
Merged
Merged
Conversation
Contributor
Author
|
@coderabbitai review Please review exact head |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the idle worker's recurring 1 ms poll by waking it on successful request admission or shutdown. Keep the configured idle coalescing window (3 ms by default), normal coalescing, first-request timeout, and batch limits. Caller-formed batches continue to bypass this loop.
Refs #373 as partial progress. This preserves the existing accumulation policy and does not establish sub-millisecond idle dispatch, strict whole-burst fusion, or throughput equivalence. PR #658 remains separate with its existing human review hold and unmet qualification criteria. No GPU or performance claim is made here.
Validation: 377 CPU tests passed, including 15 new controls for wakeup races, cancellation/shutdown, and the original lone/burst coalescing behavior. Ruff lint, formatting, and type checks pass.
Summary by CodeRabbit