Support explicit library types and independent nested package installs - #27
Open
sean-parent wants to merge 5 commits into
Open
sean-parent wants to merge 5 commits into
sean-parent wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The installed parent target drops its transitive leaf linkage because the dependency is build-interface-only.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds explicit compiled-library types and package-specific install controls for nested libraries.
Changes:
- Adds
LIBRARY_TYPE STATIC|SHAREDandINSTALL_OPTION. - Scopes deferred installation metadata per target.
- Adds nested-install and target-type regressions to CI.
| File | Description |
|---|---|
cpp-library.cmake |
Parses and forwards new options. |
cmake/cpp-library-setup.cmake |
Creates explicit static/shared targets. |
cmake/cpp-library-install.cmake |
Adds independent install options and target-scoped metadata. |
README.md |
Documents new APIs and regressions. |
.github/workflows/ci.yml |
Runs added tests. |
tests/setup/test_target_type.cmake |
Tests target-type behavior and diagnostics. |
tests/setup/fixtures/target_type/CMakeLists.txt |
Configures target-type cases. |
tests/setup/fixtures/target_type/src/sample.cpp |
Provides compiled fixture source. |
tests/setup/fixtures/target_type/include/fixture/sample.hpp |
Provides fixture API. |
tests/install/test_nested_install.cmake |
Exercises nested installation scenarios. |
tests/install/fixtures/nested/CMakeLists.txt |
Defines the parent package and dependency. |
tests/install/fixtures/nested/include/stlab/parent.hpp |
Provides parent fixture API. |
tests/install/fixtures/nested/leaf/CMakeLists.txt |
Defines the nested leaf package. |
tests/install/fixtures/nested/leaf/include/stlab/leaf.hpp |
Provides leaf fixture API. |
tests/install/fixtures/consumer/CMakeLists.txt |
Configures the installed-package consumer. |
tests/install/fixtures/consumer/main.cpp |
Exercises installed fixture APIs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Exercise transitive linkage with a compiled leaf and a parent-only consumer. Document deferred install-interface target resolution for separately installed dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIBRARY_TYPE STATIC|SHAREDwithout changing defaultBUILD_SHARED_LIBSbehavior.INSTALL_OPTIONand target-scoped deferred install metadata, allowing independent same-namespace package installation.This enables the standalone stlab/stlab-execution extraction and STLab's transitive dependency.
Validation
No release is created by this PR. Merge/release this support before publishing execution, then STLab.
Generated with GitHub Copilot CLI