fix(runtime): preserve slotted node order - #6927
Draft
wessmeister wants to merge 1 commit into
Draft
wessmeister wants to merge 1 commit into
wessmeister wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Scoped SSR hydration can move following text before a slotted shadow component when that child is defined before its parent.
Fixes #6926.
What is the new behavior?
Leave the current host's parent-owned
c-idfor its enclosing component to process. Continue hydrating the host's descendants normally. Child and text order is preserved without requiring a particular custom-element definition order.Documentation
No public API or setup change.
Does this introduce a breaking change?
Testing
Other information
The shared reproduction includes a direct Stencil control and instructions for testing the built packages. Its React example also requires the separate server-serialization correction in output-targets #853. The raw Stencil control isolates this runtime defect without React or Next.js.