Repository navigation
Conversation
Signed-off-by: apentori <pentori.alexis@proton.me>
089230e to
1196cee
Compare
Signed-off-by: apentori <pentori.alexis@proton.me>
dffbb79 to
e3c68d8
Compare
nickninov
left a comment
There was a problem hiding this comment.
IMO you need to refactor the code for status-bot (engagement.py) to be split into separate sub modules that handle and do different things.
Current critical bot bugs that have been raised in previous status-bot PR:
-
Bot can be randomly added to group chat. / communities
Fix: Bot does not listen to group chat / community messages
Expected: Bot does not listen to group chat / community messages and leaves the group chat / community -
Bot must be split into separate modules to handle different behaviours. This makes team collaboration easier and faster.
PR:
4d78cb2 to
f5e67ba
Compare
To split in the sub module i need to have all the message in one entry point, not call muiltiple listener per type of messages.
That's clearly not a critical bug, that's not even a bug since it's a design choice
The bot is currently loading multiple Module, the engagement is one of them, |
Signed-off-by: apentori <pentori.alexis@proton.me>
f5e67ba to
791176d
Compare
Signed-off-by: apentori <pentori.alexis@proton.me>
Fix missing element from 1.3.0