Skip to content

fix: adding missing ContentType - #75

Open
apentori wants to merge 4 commits into
masterfrom
fix-content-enum
Open

apentori wants to merge 4 commits into
masterfrom
fix-content-enum

Conversation

@apentori

@apentori apentori commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Fix missing element from 1.3.0

@apentori
apentori requested a review from nickninov October 12, 2026 16:07
@apentori apentori self-assigned this Oct 12, 2026
Signed-off-by: apentori <pentori.alexis@proton.me>
Signed-off-by: apentori <pentori.alexis@proton.me>
Comment thread status_sdk/types.py
Comment thread status_sdk/types.py Outdated
Comment thread status_sdk/types.py
Comment thread status_sdk/models/message.py
Comment thread CHANGELOG.md Outdated

@nickninov nickninov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO you need to refactor the code for status-bot (engagement.py) to be split into separate sub modules that handle and do different things.

Current critical bot bugs that have been raised in previous status-bot PR:

  1. Bot can be randomly added to group chat. / communities
    Fix: Bot does not listen to group chat / community messages
    Expected: Bot does not listen to group chat / community messages and leaves the group chat / community

  2. Bot must be split into separate modules to handle different behaviours. This makes team collaboration easier and faster.

PR:

@apentori
apentori force-pushed the fix-content-enum branch 6 times, most recently from 4d78cb2 to f5e67ba Compare October 13, 2026 18:25
@apentori

Copy link
Copy Markdown
Contributor Author

IMO you need to refactor the code for status-bot (engagement.py) to be split into separate sub modules that handle and do different things.

To split in the sub module i need to have all the message in one entry point, not call muiltiple listener per type of messages.

Current critical bot bugs that have been raised in previous status-bot PR:
Bot can be randomly added to group chat. / communities
Fix: Bot does not listen to group chat / community messages
Expected: Bot does not listen to group chat / community messages and leaves the group chat / community

That's clearly not a critical bug, that's not even a bug since it's a design choice

Bot must be split into separate modules to handle different behaviors. This makes team collaboration easier and faster.

The bot is currently loading multiple Module, the engagement is one of them,

Signed-off-by: apentori <pentori.alexis@proton.me>
Signed-off-by: apentori <pentori.alexis@proton.me>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants