Repository navigation
Conversation
The root resolution pinned shell-quote to 1.9.0 (#236), which is now affected by GHSA-pqg4-j6r4-53mv (quote() command injection, fixed in 1.11.0). Both consumers already declare compatible ranges (launch-editor ^1.8.4, react-devtools-core ^1.6.1), so removing the pin lets them resolve naturally to the patched 1.12.0 without an override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the root
resolutionspin"shell-quote": "1.9.0", soshell-quoteresolves normally to the patched1.12.0.The pin was added in #236 to fix an earlier shell-quote advisory. Since then,
1.9.0has itself become affected by a critical advisory:quote()command injection through a line terminator in a token after a{ comment }token>=1.8.4 <1.11.0Both consumers already declare ranges that include the patched versions, so no override is needed:
example→@react-native-community/cli-tools→launch-editor@2.14.1(shell-quote@^1.8.4)example→react-native@0.84.0→react-devtools-core@6.1.5(shell-quote@^1.6.1)Removing the pin instead of bumping it means it can't become outdated the way the
1.9.0pin did.Changes
package.json: remove"shell-quote": "1.9.0"fromresolutionsyarn.lock: one entry changes,shell-quote1.9.0→1.12.0. No other packages change.Compatibility
shell-quote1.12.0has the same module shape, exports and engines as1.9.0, and no dependencies. The changes are the security fix inquote()plus recognition of extra shell operators.shell-quoteis only loaded bylaunch-editor, which callsparse()on the editor command (react-devtools-core's dist files don't require it). On editor-command inputs,parse()andquote()output was identical between1.9.0and1.12.0(23 cases).Test plan
Run locally on Node 22 and 24 (the CI matrix):
yarn install --immutableyarn compileyarn lint(output identical tomain)yarn buildyarn test:ci: 22/22 passedyarn why shell-quote: both paths resolve1.12.0yarn workspace example react-native configloads, andlaunch-editoreditor-command parsing worksyarn npm audit --all --recursive: 37 → 36 findings (shell-quote resolved, nothing new)The
minimatchfix is in a separate PR (fix/security-minimatch).🤖 Generated with Claude Code