Skip to content

chore(all): batch transitive dependency upgrades for security alerts #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fefi95 merged 11 commits into from
Oct 21, 2026
+1,555 −2,480
Merged

chore(all): batch transitive dependency upgrades for security alerts #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
092899e
chore(all): bump turbo to 2.x and migrate turbo.json to tasks
Oct 15, 2026
bb66439
chore(all): bump typedoc to 0.28 with matching plugins
Oct 15, 2026
113571b
chore(all): bump semantic-release to 25.x
Oct 15, 2026
a4f0ec7
test(native): type fixture with ReactElement instead of global JSX
Oct 15, 2026
e4b4c07
chore(all): yarn dedupe
Oct 15, 2026
cba4a9e
chore(all): refresh vulnerable transitive deps within existing ranges
Oct 15, 2026
6befab7
chore(all): bump mocha to 12.x
Oct 15, 2026
257bdb0
chore(all): align root engines with mocha 12
Oct 15, 2026
3f1c7ff
chore(all): don't cache the turbo docs task
Oct 15, 2026
8495f57
chore(all): pass CI and OIDC env vars through to the turbo release task
Oct 19, 2026
715c8b2
chore(all): bump @types/mocha to ^10.0.10
Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/mocha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"devDependencies": {
"@assertive-ts/core": "workspace:^",
"@examples/symbol-plugin": "workspace:^",
"@types/mocha": "^10.0.6",
"@types/mocha": "^10.0.10",
"@types/node": "^24.10.1",
"mocha": "^11.8.0",
"mocha": "^12.0.3",
"ts-node": "^10.9.2",
"typescript": "^5.9.3"
}
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"author": "Stack Builders <info@stackbuilders.com>",
"license": "MIT",
"engines": {
"node": ">=20"
"node": "^20.19.0 || >=22.12.0"
},
"packageManager": "yarn@4.1.0",
"workspaces": [
Expand All @@ -18,14 +18,14 @@
"tar": "7.5.22"
},
"scripts": {
"check": "turbo check && yarn lint",
"check": "turbo run check && yarn lint",
"clean": "rimraf **/.turbo/ **/build/ **/dist/ **/node_modules/",
"build": "turbo run build",
"compile": "turbo run compile",
"docs": "turbo docs",
"docs": "turbo run docs",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"release": "turbo release --concurrency=1",
"release": "turbo run release --concurrency=1",
"test": "turbo run test"
},
"devDependencies": {
Expand All @@ -49,7 +49,7 @@
"globals": "^16.5.0",
"react-native-safe-area-context": "^5.5.2",
"rimraf": "^6.1.2",
"turbo": "^1.12.4",
"turbo": "^2.11.8",
"typescript": "^5.9.3",
"typescript-eslint": "^8.47.0"
}
Expand Down
12 changes: 6 additions & 6 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@
"tslib": "^2.8.1"
},
"devDependencies": {
"@types/mocha": "^10.0.6",
"@types/mocha": "^10.0.10",
"@types/node": "^24.10.1",
"@types/sinon": "^17.0.3",
"all-contributors-cli": "^6.26.1",
"mocha": "^11.8.0",
"semantic-release": "^23.1.1",
"mocha": "^12.0.3",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mocha@12 requires Node ^20.19.0 || >=22.12.0, and semantic-release@25 requires ^22.14.0 || >=24.10.0. The root engines.node is still >=20, so the engines plugin lets someone on Node 20.11 / 22.0 install and then fail with a confusing error in yarn test / yarn release. CI is fine because it resolves the latest 20/22/24. Should we raise the root engines.node to ^20.19.0 || >=22.12.0?

@fefi95 fefi95 Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 257bdb0: root engines.node is now ^20.19.0 || >=22.12.0. The release job reads .nvmrc (25.2.1), which also satisfies semantic-release 25.

"semantic-release": "^25.0.9",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is two majors of semantic-release (and commit-analyzer 12 → 13, @semantic-release/github → 12). Since yarn release wasn't run for real, could you double-check that the releaseRules scope negations in .releaserc.json (!core, !all, …) still match the same way under commit-analyzer 13? If not, the first release after merge could publish every package for a commit scoped to one package, or publish none.

@fefi95 fefi95 Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked by running analyzeCommits from commit-analyzer 12.0.0 (main's lockfile) and 13.0.1 (this PR) with the packages/core/.releaserc.json rules on the same commits. Results are identical:

Commit 12.0.0 13.0.1
feat(core), fix(core), feat(dom), feat(all), chore(all) no release no release
feat: minor minor
fix: patch patch
feat(core)!: + BREAKING CHANGE major major

Unchanged by this PR, but worth knowing: with these rules a scoped feat(core) / fix(core) doesn't trigger a release on either version.

"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"publishConfig": {
Expand Down
12 changes: 6 additions & 6 deletions packages/dom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,23 @@
"@testing-library/dom": "^10.1.0",
"@testing-library/react": "^16.0.0",
"@types/jsdom-global": "^3",
"@types/mocha": "^10.0.6",
"@types/mocha": "^10.0.10",
"@types/node": "^24.10.1",
"@types/react": "^19.2.0",
"@types/react-dom": "^18.3.0",
"@types/react-test-renderer": "^19.1.0",
"jsdom": "^24.0.0",
"jsdom-global": "^3.0.2",
"mocha": "^11.8.0",
"mocha": "^12.0.3",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same mocha / semantic-release / typedoc* bumps are hand-edited in core, dom, native, sinon and examples/mocha. We could hoist them to the root devDependencies so the next upgrade is a single edit and can't drift. That's fine as a follow-up and doesn't need to be in this PR.

@fefi95 fefi95 Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, leaving the hoisting for a follow-up so this PR stays scoped to the alerts.

"react": "19.2.3",
"react-dom": "19.2.3",
"react-test-renderer": "19.2.3",
"semantic-release": "^23.1.1",
"semantic-release": "^25.0.9",
"semantic-release-yarn": "^3.0.2",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"peerDependencies": {
Expand Down
12 changes: 6 additions & 6 deletions packages/native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,23 @@
"devDependencies": {
"@assertive-ts/core": "workspace:^",
"@testing-library/react-native": "^12.9.0",
"@types/mocha": "^10.0.6",
"@types/mocha": "^10.0.10",
"@types/node": "^24.10.1",
"@types/react": "^19.2.0",
"@types/react-test-renderer": "^19.1.0",
"@types/sinon": "^17.0.3",
"mocha": "^11.8.0",
"mocha": "^12.0.3",
"react": "19.2.3",
"react-native": "0.84.0",
"react-native-testing-mocks": "^1.7.0",
"react-test-renderer": "19.2.3",
"semantic-release": "^23.1.1",
"semantic-release": "^25.0.9",
"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/native/test/lib/fixtures/simpleToggleText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useCallback, useState } from "react";
import { type ReactElement, useCallback, useState } from "react";
import { Button, Text, View } from "react-native";

export function SimpleToggleText(): JSX.Element {
export function SimpleToggleText(): ReactElement {
const [visible, setVisible] = useState(true);

const toggle = useCallback(() => {
Expand Down
12 changes: 6 additions & 6 deletions packages/sinon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,17 @@
},
"devDependencies": {
"@assertive-ts/core": "workspace:^",
"@types/mocha": "^10.0.6",
"@types/mocha": "^10.0.10",
"@types/node": "^24.10.1",
"@types/sinon": "^17.0.3",
"mocha": "^11.8.0",
"semantic-release": "^23.1.1",
"mocha": "^12.0.3",
"semantic-release": "^25.0.9",
"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"peerDependencies": {
Expand Down
8 changes: 5 additions & 3 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://turborepo.org/schema.json",
"pipeline": {
"$schema": "https://turborepo.com/schema.json",
"tasks": {
"build": {
"dependsOn": ["^build"],
"inputs": ["src/**"],
Expand All @@ -15,13 +15,15 @@
"outputs": ["build/**"]
},
"docs": {
"cache": false,
"dependsOn": ["^build"],
"inputs": ["src/**", "typings/**"],
"outputs": ["docs/*/build/**"]
},
"release": {
"cache": false,
"dependsOn": ["^build"]
"dependsOn": ["^build"],
"passThroughEnv": ["CI", "GITHUB_*", "GH_*", "NPM_*", "YARN_*", "ACTIONS_*", "RUNNER_*", "GIT_*", "SEMANTIC_RELEASE_*", "DEBUG"]
},
"test": {
"dependsOn": ["^build"],
Expand Down
Loading
Loading