Repository navigation
Validate Message role field to prevent silent LLM API failures - #41
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified the diff is a single 4-line __post_init__ on Message that rejects None/empty/whitespace-only roles, matching the PR title and description with no unrelated changes. It follows the same not x or not x.strip() validation pattern already used by add_system/add_user/add_tool_result in the same file, and every internal construction site (add_system, add_user, add_assistant, add_tool_result) passes a hardcoded valid role, so no existing call path regresses; the only other site is load(), where a corrupt saved conversation already raised on a missing role key. No security or error-swallowing concerns — the change surfaces failures earlier rather than hiding them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
__post_init__validation to Message dataclass to reject None or empty role fields.Why
Message objects with missing or empty roles silently fail at the LLM API layer, making bugs hard to trace. Early validation at construction time catches the issue immediately.