Repository navigation
fix(drivers): bundle tesla_wall_connector 0.1.2, no power through an open contactor - #1952
Merged
Merged
Conversation
…open contactor Moves the pin to srcfl/device-drivers@107eb609 (#204). Only the Tesla Wall Connector driver changes. The test copy in go/internal/drivers/testdata was still the version from #978; it now matches the bundled driver, and the tests follow its contract: Core refuses control of the read-only driver, legs at 0 V carry no power, and an open contactor is idle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A user on v0.157.3-beta.1 (Home Assistant app) reported an idle Tesla Wall Connector Gen 3 showing 184–284 W of charging power with no car connected. With the contactor open, the unit reads 0.5–1 A of sensor offset on its legs while the leg voltages read 0 V (they are measured on the car side of the contactor). The driver multiplied that current by the grid voltage. Fixed in srcfl/device-drivers#204 (tesla_wall_connector 0.1.2, merged as
107eb609).What
drivers/BUNDLED_SOURCE.json:46b28a1→107eb609. Onlytesla_wall_connector.luadiffers between the two commits.go/internal/drivers/testdata/tesla_wall_connector.luawas still the copy from feat(ev): add Tesla Wall Connector Gen 3 local HTTP #978, behind the bundled driver. It is now byte-identical to 0.1.2, and the Go tests follow the driver's contract:read_onlyrefusal (the driver's catalog marks it read-only; with the shipped driver this test already failed against the real file);TestTeslaWallConnectorLegsAtZeroCarryNoPower, the old fallback case);grid_v × vehicle_current_a;TestTeslaWallConnectorOpenContactorIsIdle, the reported case).Evidence
scripts/sync-bundled-drivers.shfetched the 44 drivers at the new pin;--checkpasses.go test ./internal/drivers/... ./internal/fleetping/... ./internal/evcloud/...pass locally.drivers,dco,public-boundary, secret scan and signed-channel checks; main had not moved since those ran.🤖 Generated with Claude Code