-
-
Notifications
You must be signed in to change notification settings - Fork 173
Make chart data point links clickable #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lovasoa
wants to merge
12
commits into
main
Choose a base branch
from
fix-chart-tooltip-link-hover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f8f2b28
feat(chart): add links to data point tooltips (#1438)
lovasoa 427a735
Fix chart tooltip links on hover
lovasoa a8c8082
Link chart tooltip titles
lovasoa 3945c7b
Make chart point links clickable
lovasoa 6109413
Rely on ApexCharts for interactive tooltips
lovasoa f01b713
feat(chart): enable linked points with interactive tooltips
lovasoa d270265
Merge existing chart-link PR history into updated implementation
lovasoa 048ff9f
Merge branch 'main' into fix-chart-tooltip-link-hover
lovasoa b41e4eb
Merge branch 'main' into fix-chart-tooltip-link-hover
lovasoa 5705fb0
Merge branch 'main' into fix-chart-tooltip-link-hover
lovasoa 69d81d7
refactor apexcharts datapoints handling to use well typed objects
lovasoa e71a8a4
Keep native chart tooltips and link text X titles
lovasoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| SELECT 'chart' AS component, 'test-chart' AS id, 'Chart test fixture' AS title, | ||
| 'bar' AS type; | ||
| SELECT 'Points' AS series, 'Linked' AS label, 10 AS value, '/linked.sql' AS link; | ||
| SELECT 'Points' AS series, 'Linked too' AS label, 20 AS value, '/linked-too.sql' AS link; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| SELECT 'chart' AS component, 'test-chart' AS id, 'Chart test fixture' AS title, | ||
| 'line' AS type, 8 AS marker; | ||
| SELECT 'Points' AS series, 1 AS x, 10 AS y, '/linked.sql' AS link; | ||
| SELECT 'Points' AS series, 2 AS x, 20 AS y, '/linked-too.sql' AS link; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| SELECT 'chart' AS component, 'test-chart' AS id, 'Chart test fixture' AS title, | ||
| 'pie' AS type; | ||
| SELECT 'Points' AS series, 'A' AS label, 10 AS value, '/linked.sql' AS link; | ||
| SELECT 'Points' AS series, 'B' AS label, 20 AS value, '/linked-too.sql' AS link; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| SELECT 'chart' AS component, 'test-chart' AS id, 'Chart test fixture' AS title, | ||
| 'scatter' AS type, 8 AS marker; | ||
| SELECT 'Points' AS series, 1 AS x, 1 AS y, '/linked.sql' AS link; | ||
| SELECT 'Points' AS series, 2 AS x, 2 AS y, '/linked-too.sql' AS link; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| SELECT 'chart' AS component, 'test-chart' AS id, 'Chart test fixture' AS title, | ||
| 'line' AS type, TRUE AS time, 8 AS marker; | ||
| SELECT 'Points' AS series, '2024-03-01' AS x, 10 AS y, '/linked.sql' AS link; | ||
| SELECT 'Points' AS series, '2024-03-02' AS x, 20 AS y, '/linked-too.sql' AS link; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| SELECT 'chart' AS component, 'test-chart' AS id, 'Chart test fixture' AS title, | ||
| 'rangeBar' AS type, TRUE AS time; | ||
| SELECT 'Design' AS series, 'Alice' AS label, | ||
| '2024-03-01' AS value, '2024-03-05' AS value, | ||
| '/workpackage_edit.sql?workpackage_name=Design' AS link; | ||
| SELECT 'Research' AS series, 'Bob' AS label, | ||
| '2024-03-06' AS value, '2024-03-10' AS value; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention for the tooltip to change like this when a link has been added? IMO it makes more sense not to do this and just hyperlink the title (ie ::
Tomin this case)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed and addressed in e71a8a4: the linked chart now keeps ApexCharts' native tooltip and hyperlinks only the text X title ("Tom" in your example). I explained the numeric/date and no-title tradeoff and attached before/after screenshots in this PR comment.