Allow simplecov 1.x while keeping Ruby 3.1/3.2 installable - #765
Merged
Merged
Conversation
simplecov 1.3.0 requires Ruby >= 3.3, so pinning `~> 1.3` (as proposed in splitrb#764) breaks bundle resolution on Ruby 3.1 and 3.2, which split still supports. Widen the requirement to `>= 0.15, < 2` so Bundler picks the newest simplecov compatible with each Ruby (0.22 on 3.1, 1.2 on 3.2, 1.3 on 3.3+). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
andrehjr
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #764.
#764 bumps simplecov to
~> 1.3, but simplecov 1.3.0+ declaresrequired_ruby_version >= 3.3. Since split still supports Ruby >= 3.1,bundle lockfails on the Ruby 3.1 and 3.2 jobs:(The Ruby 3.3+ jobs in #764 were cancelled by fail-fast, not failing on their own.)
This PR widens the requirement to
>= 0.15, < 2instead, so Bundler resolves the newest simplecov compatible with each Ruby. There is no committedGemfile.lock, so each CI job resolves independently. The spec helper only callsSimpleCov.start, which behaves the same on 0.x and 1.x.Verification (local)
RuboCop: no offenses.
🤖 Generated with Claude Code