Repository navigation
fix: refresh sorted visits after flag normalization - #543
Closed
ViktorBystrov72 wants to merge 1 commit into
Closed
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Signed-off-by: Виктор Быстров <anatema@bk.ru>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlagSet.Visitreuses its sorted cache afterSetNormalizeFuncrenames flags. If the new names sort differently, visits no longer follow the documented lexicographical order. For example, visitingmiddle,zulu, then aliasingzulutoalpha, producesmiddle,alphainstead ofalpha,middle.Invalidate the sorted set-flag cache alongside the existing declared-flag cache. The regression test populates the cache before normalization and checks both sorted visits and insertion-order visits, including an unset flag that must remain excluded.
Validation on macOS arm64 with Go 1.27.3:
[middle alpha], then passes with this change.go test -race -count=1 ./...passes.golangci-lint run ./...(2.14.0) reports no issues.gofmtandgit diff --checkpass.The older Go versions in the CI matrix were not run locally; the change uses the module's existing Go 1.12-compatible syntax.