Repository navigation
Conversation
Ekko82
reviewed
Oct 30, 2026
Ekko82
left a comment
There was a problem hiding this comment.
I ran the three new ParseSkippedFlags test functions on Windows/386 with Go 1.27.1 (GOOS=windows, GOARCH=386, CGO_ENABLED=0), supplementing the compile-only 386 result in the description:
go test -json -count=1 -run '^TestParseSkippedFlags(SeparateValues|MissingOrUnknownFlag|CustomBoolFlag)$' .All 15 leaf cases passed at 5b8b51e675bb1a685b8b3a529b5ed3516413f24e with the PR sources unchanged. I did not run the full suite, race tests or other Go versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseSkippedFlagscurrently keeps only arguments starting with-test.. A valid pair such as-test.run TestExampletherefore loses its value; with mixed flags it can consume a later test flag as that value instead.Keep the following argument for a registered non-boolean test flag. Equals-form values and boolean flags remain unchanged, including custom values implementing
IsBoolFlag(). Let Go's parser continue reporting unknown flags and missing/invalid values. No changes to pflag's main parser or delimiter behavior.The regression fails on unchanged production code for ten table cases and a custom non-boolean flag. Full race suites pass on Go 1.27.3 and 1.26.10; vet and configured golangci-lint 2.13.2 on Go 1.26.10 pass. An additional 34-case comparison agrees with Go's parser. The 386 test binary compiles but cannot execute in this environment; the remaining upstream version matrix has not run.
This fixes value handling in the helper introduced by #424, rather than replacing its original #423 behavior.
AI-assisted investigation, implementation, tests and writing; independently reviewed. No production incident is claimed.