Repository navigation
ci(release): build and attach the Windows bundle from the release-please run - #121
Merged
Merged
Conversation
The release-please job has no checkout, so `gh workflow run` failed with "not a git repository" and no Windows bundle was built for v2.23.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ase run
Releases and tags created with GITHUB_TOKEN do not trigger other workflows,
and the gh workflow run hand-off failed for v2.23.0 ("not a git
repository"). The Windows bundle is now a reusable workflow
(workflow_call) that release-please.yml calls as a second job when a
release is created.
- build-portable-windows.yml: workflow_call input tag_name; checks out the
release tag; uploads with `gh release upload --clobber` (safe re-runs);
verifies that the release has the zip with the built size; one build per
tag at a time (concurrency). Manual dispatch with tag_name still works.
- release-please.yml: exports releases_created/tag_name and calls the bundle
workflow; the actions: write permission is no longer needed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
spelech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows portable bundle was not attached to v2.23.0. Releases and tags that release-please creates with
GITHUB_TOKENdo not trigger other workflows (release: published,push: tags), and thegh workflow runhand-off from #117 failed because the release-please job has no checkout:(The v2.23.0 bundle was built by hand: run 43268867692.)
Change
build-portable-windows.ymlgets aworkflow_calltrigger withtag_name. It checks out the release tag, uploads withgh release upload --clobber(a re-run replaces the asset), and a new step verifies that the release hascontextcortex-windows-x64-portable.zipwith the size of the built zip. Aconcurrencygroup allows one build per tag at a time. Manualworkflow_dispatchwithtag_namestill works; PR builds still build and smoke-test without attaching.release-please.ymlexportsreleases_createdandtag_nameand calls the bundle workflow as a second job (needs: release-please). No dispatch, no extra token; a bundle failure now shows in the release run.actions: writeis no longer needed.Verification
tag_name=v2.23.0(rebuilds the v2.23.0 code and replaces the same asset).🤖 Generated with Claude Code