Skip to content

fix: fail fast in Rust WASM build script #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FARICJH59 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fail fast in Rust WASM build script #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions rust/build_rust_wasm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,40 @@
#!/usr/bin/env bash
set -euo pipefail

WASM_TARGET="$(rustc --print sysroot 2>/dev/null)/lib/rustlib/wasm32-unknown-unknown"
# Check if "rustup" tool is installed, or the wasm32-unknown-unknown target aleady exists,
# in which case it's very likely that the required toolchain exists
if ! [ -d "$WASM_TARGET" ] && (! command -v rustup &> /dev/null); then echo "Rust tool 'rustup' not found! Please install Rust to build."
if ! command -v rustc >/dev/null 2>&1; then
echo "Rust compiler 'rustc' not found in PATH. Please install Rust to build."
exit 1
fi

if ! RUST_SYSROOT="$(rustc --print sysroot 2>/dev/null)" || [[ -z "$RUST_SYSROOT" ]]; then
echo "Unable to determine the Rust sysroot. Check your Rust toolchain installation."
exit 1
fi

WASM_TARGET="$RUST_SYSROOT/lib/rustlib/wasm32-unknown-unknown"

# Check if rustup is installed, or the wasm32-unknown-unknown target already exists.
if [[ ! -d "$WASM_TARGET" ]] && ! command -v rustup >/dev/null 2>&1; then
echo "Rust tool 'rustup' not found! Please install Rust to build."
echo "Visit Rust installation page: https://www.rust-lang.org/tools/install"
echo "- Likely install one-liner: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh"
echo "If you're using rust without rustup, make sure that the target 'wasm32-unknown-unknown' is installed"
echo "If you're using Rust without rustup, make sure that the target 'wasm32-unknown-unknown' is installed"
exit 1
fi

cd "$(dirname "$0")"

if ! [ -d "$WASM_TARGET" ]; then
# Make sure Rust wasm target is installed
if [[ ! -d "$WASM_TARGET" ]]; then
# Make sure the Rust wasm target is installed.
rustup target add wasm32-unknown-unknown
fi

# Make sure wasm-pack is installed
if ! command -v wasm-pack &> /dev/null; then
# Make sure wasm-pack is installed.
if ! command -v wasm-pack >/dev/null 2>&1; then
cargo install wasm-pack
fi

cd spark-rs

# Build the project with SIMD enabled
# Build the project with SIMD enabled.
RUSTFLAGS="-C target-feature=+simd128,+bulk-memory" wasm-pack build --target web --release