Repository navigation
Replace miniz_oxide with flate2 for Gzip (de)compression for SPZ - #485
Merged
Merged
Conversation
oscarlorentzon
left a comment
oscarlorentzon
left a comment
Collaborator
There was a problem hiding this comment.
The encoder looks good. The decoder changes affect memory use and file type detection.
oscarlorentzon
approved these changes
Oct 15, 2026
Contributor
|
needs rebase |
Collaborator
Author
|
@dmarcos Rebased |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #474. The SPZ encoding and decoding still used
miniz_oxidein combination with custom Gzip header parsing. This PR replaces it withGzDecoderandGzEncoderfromflate2. With this changeminiz_oxideis no longer used (directly) and has been removed as dependency fromCargo.toml. Splat formats using deflate/gzip compression now all useflate2with thezlib-rsbackend.