Repository navigation
Stop deriving the schema conversion order from the dialect order (Enterprise) - #1310
Merged
Merged
Conversation
…erprise) Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummaryDecouples Enterprise schema conversion order from 🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Benchmark (community)
Details
| Benchmark suite | Current: 4708218 | Previous: 18b9cca | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
267 ms |
273 ms |
0.98 |
Add one schema (100 existing) |
48 ms |
46 ms |
1.04 |
Add one schema (1000 existing) |
93 ms |
93 ms |
1 |
Add one schema (10000 existing) |
711 ms |
677 ms |
1.05 |
Update one schema (1 existing) |
40 ms |
35 ms |
1.14 |
Update one schema (101 existing) |
42 ms |
42 ms |
1 |
Update one schema (1001 existing) |
93 ms |
92 ms |
1.01 |
Update one schema (10001 existing) |
731 ms |
703 ms |
1.04 |
Cached rebuild (1 existing) |
14 ms |
11 ms |
1.27 |
Cached rebuild (101 existing) |
15 ms |
14 ms |
1.07 |
Cached rebuild (1001 existing) |
41 ms |
40 ms |
1.02 |
Cached rebuild (10001 existing) |
310 ms |
292 ms |
1.06 |
Index 100 schemas |
409 ms |
429 ms |
0.95 |
Index 1000 schemas |
1338 ms |
1313 ms |
1.02 |
Index 10000 schemas |
12607 ms |
12856 ms |
0.98 |
Index 10000 schemas (custom meta-schema) |
16105 ms |
16069 ms |
1.00 |
Index 10000 schemas ($ref fan-out) |
15141 ms |
15220 ms |
0.99 |
test/e2e/html: Schema Fetch (p50) |
397 us |
401 us |
0.99 |
test/e2e/html: Schema Fetch (p99) |
491 us |
487 us |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark (enterprise)
Details
| Benchmark suite | Current: 4708218 | Previous: 18b9cca | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
495 ms |
306 ms |
1.62 |
Add one schema (100 existing) |
130 ms |
81 ms |
1.60 |
Add one schema (1000 existing) |
187 ms |
158 ms |
1.18 |
Add one schema (10000 existing) |
921 ms |
813 ms |
1.13 |
Update one schema (1 existing) |
110 ms |
75 ms |
1.47 |
Update one schema (101 existing) |
127 ms |
84 ms |
1.51 |
Update one schema (1001 existing) |
185 ms |
141 ms |
1.31 |
Update one schema (10001 existing) |
947 ms |
853 ms |
1.11 |
Cached rebuild (1 existing) |
13 ms |
10 ms |
1.30 |
Cached rebuild (101 existing) |
14 ms |
13 ms |
1.08 |
Cached rebuild (1001 existing) |
38 ms |
36 ms |
1.06 |
Cached rebuild (10001 existing) |
227 ms |
262 ms |
0.87 |
Index 100 schemas |
687 ms |
514 ms |
1.34 |
Index 1000 schemas |
1646 ms |
1241 ms |
1.33 |
Index 10000 schemas |
14969 ms |
11785 ms |
1.27 |
Index 10000 schemas (custom meta-schema) |
15816 ms |
11546 ms |
1.37 |
Index 10000 schemas ($ref fan-out) |
19099 ms |
14090 ms |
1.36 |
enterprise/e2e/auth: Schema Anonymous (p50) |
302 us |
208 us |
1.45 |
enterprise/e2e/auth: Schema Anonymous (p99) |
402 us |
293 us |
1.37 |
enterprise/e2e/auth: Schema API Key Identity (p50) |
311 us |
213 us |
1.46 |
enterprise/e2e/auth: Schema API Key Identity (p99) |
417 us |
366 us |
1.14 |
enterprise/e2e/auth: Schema API Key SHA256 (p50) |
322 us |
221 us |
1.46 |
enterprise/e2e/auth: Schema API Key SHA256 (p99) |
440 us |
408 us |
1.08 |
enterprise/e2e/auth: Schema JWT (p50) |
487 us |
308 us |
1.58 |
enterprise/e2e/auth: Schema JWT (p99) |
645 us |
409 us |
1.58 |
test/e2e/html: Schema Fetch (p50) |
319 us |
223 us |
1.43 |
test/e2e/html: Schema Fetch (p99) |
422 us |
279 us |
1.51 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com