Skip to content

fix(skills/reporting-a-skill-gap): let the location block hold several skills - #89

Merged
sourcehawk merged 2 commits into
mainfrom
fix/skill-gap-template-multiple-skills
Oct 6, 2026
Merged

sourcehawk merged 2 commits into
mainfrom
fix/skill-gap-template-multiple-skills

Conversation

@sourcehawk

@sourcehawk sourcehawk commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Description

Fixes #82

A skill-gap report about two skills could not follow its own template. The guidance under ## Where in the plugin said "Exactly these three lines" and, in the same comment, told the agent to repeat the Skill and Section lines for each skill. Now it asks for one Skill and Section pair for each skill, then one Plugin version line at the end.

The test runs showed two more gaps for a report about two skills, and this PR fixes them too. The title rule named "the skill" in the singular. ## Reproduction gave no shape for a gap that spans an agent and the agents it dispatches, so one run wrote a predicate that needed a second run that the scenario did not describe.

Changes

  • templates/skill-gap.md: the guidance comment under ## Where in the plugin defines the shape for any number of skills, and says where the version line goes.
  • templates/skill-gap.md: the title rule names each skill, joined with "and", when more than one skill is involved.
  • templates/skill-gap.md: the ## Reproduction guidance says that a gap across a dispatching agent and its dispatched agents gets one scenario for the agent that dispatches. Its Task prompt is the message that agent receives, its Environment facts name the skill that each dispatched agent follows, and its Failure predicate checks the dispatch prompts and what the dispatched agents do, in the same run.

Testing

Tested with isolated subagents and the issue's two-skill task.

  • Location block: with the old template, both runs wrote the right shape, but only by guessing: each pointed out the conflict between "exactly three lines" and "repeat for each", and one could not tell how often the version line goes in. With the new guidance, the run wrote two Skill and Section pairs and one version line, and it noted no difficulty with the section. No other text under skills/ says "three lines".
  • Title and reproduction: with the singular title rule and no reproduction guidance for two skills, one of three runs said that the title rule names "the skill" in the singular. All three said the template had no shape for a scenario across a dispatcher and its dispatched agents. Two wrote the scenario from the dispatcher's side, and one from the dispatched agent's side, with a predicate that needed a second run. With the new guidance, both runs wrote one scenario for the dispatcher. Each scenario named the dispatched agents' skill in Environment facts, and each predicate could be checked in that one run. One run said the guidance "was clear and easy to apply".

🤖 Generated with Claude Code

…han one skill

The template said that `## Where in the plugin` holds "exactly these three lines", and the same comment said to repeat the Skill and Section lines when more than one skill is involved. A report about two skills cannot obey both rules. The guidance now asks for one Skill and Section pair for each skill, then one Plugin version line at the end.

Fixes #82

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused guidance change resolves the formatting conflict and matches #82’s requirements.

Review effort: Balanced
Findings: None

What changed in this PR

Resolves #82 by clarifying the skill-gap report template’s guidance for gaps involving multiple skills.

Changes:

  • Replaces the three-line restriction with one Skill/Section pair per skill.
  • Specifies one Plugin version line at the end.
File Description
skills/​reporting-a-skill-gap/​templates/​skill-gap.md Updates the guidance comment to define multi-skill location blocks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…shape for two skills

The title rule named "the skill" in the singular, and `## Reproduction` gave no shape for a gap that spans an agent and the agents it dispatches. Test runs on a two-skill report guessed at both. One wrote a predicate that needed a second run which the scenario did not describe. The title rule now names each skill, joined with "and". The reproduction guidance asks for one scenario for the agent that dispatches, whose predicate checks the dispatch prompts and what the dispatched agents do in the same run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 10:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused template clarifications resolve the documented ambiguities without introducing conflicting requirements.

Review effort: Balanced
Findings: None

@sourcehawk
sourcehawk merged commit f4611dd into main Oct 6, 2026
6 checks passed
@sourcehawk
sourcehawk deleted the fix/skill-gap-template-multiple-skills branch October 6, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reporting-a-skill-gap: the template's three-line location block cannot hold a report about two skills

2 participants