Skip to content

ci: validate manifests offline instead of against the old dotcom cluster - #515

Merged
michaellzc merged 1 commit into
mainfrom
ci-offline-yaml-validation
Nov 19, 2026
Merged

michaellzc merged 1 commit into
mainfrom
ci-offline-yaml-validation

Conversation

@michaellzc

Copy link
Copy Markdown
Member

.buildkite/verify-yaml.sh validates the manifests with a server-side dry run against the cloud GKE cluster in sourcegraph-dev. That's the old dotcom cluster, which is being removed in sourcegraph/infrastructure#7651, and this step breaks once it's gone. This replaces the dry run with offline schema validation: the rendered base/ is checked by kubeconform v0.6.7 in -strict mode against Kubernetes 1.33 schemas. It also adds pipefail so a failing kubectl kustomize fails the step.

Offline validation doesn't catch errors only an API server reports, such as admission webhooks or unknown CRDs. base/ has no custom resources, so nothing is skipped.

Test plan

Ran the new script locally with kubectl 1.33.5:

Summary: 52 resources found parsing stdin - Valid: 52, Invalid: 0, Errors: 0, Skipped: 0

Negative control: setting replicas: "two" in base/sourcegraph/syntactic-code-intel/worker.Deployment.yaml fails the step (expected integer or null, but got string, exit 1).

Source: Amp thread

verify-yaml.sh did a server-side dry run against the cloud GKE cluster in
sourcegraph-dev, which is being removed. Validate the rendered base
manifests with kubeconform against the Kubernetes 1.33 schemas instead.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1efa3-6bd0-7476-bce2-10965139dce3
Co-authored-by: Amp <amp@ampcode.com>
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

@michaellzc
michaellzc requested a review from a team November 19, 2026 00:28

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this even have credentials to prod lel

@michaellzc

Copy link
Copy Markdown
Member Author

why did this even have credentials to prod lel

that's a great question...i didn't even know we have this until today

@michaellzc
michaellzc merged commit 0fdf59f into main Nov 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants