Repository navigation
ci: validate manifests offline instead of against the old dotcom cluster - #515
Merged
Merged
Conversation
verify-yaml.sh did a server-side dry run against the cloud GKE cluster in sourcegraph-dev, which is being removed. Validate the rendered base manifests with kubeconform against the Kubernetes 1.33 schemas instead. Amp-Thread-ID: https://ampcode.com/threads/T-01a1efa3-6bd0-7476-bce2-10965139dce3 Co-authored-by: Amp <amp@ampcode.com>
eseliger
approved these changes
Nov 19, 2026
eseliger
left a comment
Member
There was a problem hiding this comment.
why did this even have credentials to prod lel
Member
Author
that's a great question...i didn't even know we have this until today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.buildkite/verify-yaml.shvalidates the manifests with a server-side dry run against thecloudGKE cluster in sourcegraph-dev. That's the old dotcom cluster, which is being removed in sourcegraph/infrastructure#7651, and this step breaks once it's gone. This replaces the dry run with offline schema validation: the renderedbase/is checked by kubeconform v0.6.7 in-strictmode against Kubernetes 1.33 schemas. It also addspipefailso a failingkubectl kustomizefails the step.Offline validation doesn't catch errors only an API server reports, such as admission webhooks or unknown CRDs.
base/has no custom resources, so nothing is skipped.Test plan
Ran the new script locally with kubectl 1.33.5:
Negative control: setting
replicas: "two"inbase/sourcegraph/syntactic-code-intel/worker.Deployment.yamlfails the step (expected integer or null, but got string, exit 1).Source: Amp thread