Skip to content

chore: update dependencies - #970

Draft
marcleblanc2 wants to merge 1 commit into
mainfrom
marc/update-dependencies
Draft

marcleblanc2 wants to merge 1 commit into
mainfrom
marc/update-dependencies

Conversation

@marcleblanc2

@marcleblanc2 marcleblanc2 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Open issues

Found in review on 2026-11-13 (review thread). This PR is a draft until the first three are settled.

  1. Both chart publish workflows would fail. helm-gcs 0.7.0 does not install under Helm v3.22.1: plugin.yaml: json: unknown field "args" (hayorov/helm-gcs#249, still open). Reproduced locally. After merge, no insiders chart is published, and no release chart on the next release. helm-gcs 0.6.3 installs and loads under v3.22.1; a real push to the bucket was not tested
  2. Conflicts with main in the four workflows, .tool-versions, and scripts/ci/validate-schema.sh. Since this branch was cut, main pinned every action to a commit SHA (Pin GitHub Actions to commit SHAs #1006) and moved tool installs to mise and .tool-versions (ci: install helm and kubeconform with mise #996). Taking this branch's side would undo both, so the rebase means redoing the bumps on top of them. The green checks here are from the old base
  3. docker:29.9.1-dind has a known dockerd hang. Docker 29.7.0 to 29.9.2 stop answering container and image calls while /_ping still answers (moby/moby#54017), so the sidecar's probes would not restart it. Fixed in 29.9.3. Whether executor load triggers it was not tested
  4. Helm 4 has not installed a chart in CI yet. On this PR helm_lint_test.yml skipped lint, kind, helm install, and helm test, because no chart under charts/sourcegraph changed. Run it once on a branch that touches that chart before merging
  5. Small ones:
    • newer releases are already out: Helm v4.3.2, kind-action v1.15.2, gh 2.104.0
    • checkov 3.4.5 declares support for Python 3.13
    • "Buildkite installs Helm 4 unpinned from apt" is no longer true, main pins 4.3.0 through mise
    • the executor CHANGELOG.md has no entry for the dind image change

Not tested on a cluster: the conflicts mean this branch cannot be deployed as it would merge, and the one chart change, the dind image tag, needs to change again.

Summary

Bumps every pinned dependency in the repo to its current release. No chart template changes; the only chart-facing change is the executor dind sidecar image tag.

GitHub Actions

Action Before After
actions/checkout v3 / v4 v7
actions/setup-python v4 / v5 v7
github/codeql-action/upload-sarif v3 v4
azure/setup-helm v1 / v3 v5
azure/setup-kubectl v2.0 v5
google-github-actions/auth v0 v3
helm/chart-testing-action v2.2.1 v2.9.0
helm/kind-action v1.3.0 v1.15.1

Tool versions

Tool Where Before After
Helm gcs_chart_publish_*.yml v3.4.0 v3.22.1
Helm helm_lint_test.yml v3.9.1 v4.3.1
helm-gcs gcs_chart_publish_*.yml 0.3.20 0.7.0
helm-unittest scripts/ci/helm-unittest.sh v1.0.2 v1.2.1
kubeconform scripts/ci/validate-schema.sh v0.4.12 v0.8.0
github-cli .tool-versions 2.46.0 2.102.0
Python helm_lint_test.yml 3.13 3.14

Charts

Image Before After
executor dind docker 29.5.3-dind 29.9.1-dind

Already current, unchanged

helm-docs 1.14.2, comby 1.8.1, sourcegraph/backport@v2. Checkov stays on Python 3.12, the newest version checkov declares support for.

Decisions worth a look

  • Publish workflows stay on Helm 3 (latest, v3.22.1), not Helm 4. The release path can't be exercised from a PR, and helm-gcs 0.7.0 installs a different plugin layout under Helm 4 (gcs + gcs-getter, needs --verify=false). Buildkite CI already installs Helm 4 unpinned from the Buildkite apt repo (4.3.0 today), and helm_lint_test.yml now runs Helm 4.3.1 too, so the charts get Helm 4 coverage on every PR. Tracked as a follow-up in dev/TODO.md.
  • helm-unittest v1.0.2 → v1.2.1. The old comment pinned 1.0.2 because 1.0.3 broke helm plugin install (Error when installing via helm plugin install helm-unittest/helm-unittest#790). That issue is closed and the install hook's Linux path is plain GNU sha256sum -c --status.
  • google-github-actions/auth@v3 still accepts credentials_json; service_account is only required for workload identity and is harmless alongside a JSON key.

Test plan

Run locally on macOS with Helm 4.3.0:

  • helm unittest -q charts/sourcegraph with helm-unittest 1.2.1: 32 suites, 195 tests, 12 snapshots, all passed
  • helm lint on all four charts: 0 failed
  • kubeconform 0.8.0 -summary -strict on helm template output of all four charts: 81 resources valid, 0 invalid, 0 errors
  • ./scripts/helm-docs.sh regenerated; only diff is the dind tag in charts/sourcegraph-executor/dind/README.md
  • All new action tags resolve as git refs; helm-v3.22.1 and helm-v4.3.1 download from get.helm.sh
  • Buildkite + helm_lint_test.yml on this PR exercise the Linux install paths for helm-unittest 1.2.1, kubeconform 0.8.0, and the bumped actions

…ersions

GitHub Actions:
- actions/checkout v3/v4 -> v7
- actions/setup-python v4/v5 -> v7
- github/codeql-action/upload-sarif v3 -> v4
- azure/setup-helm v1/v3 -> v5
- azure/setup-kubectl v2.0 -> v5
- google-github-actions/auth v0 -> v3
- helm/chart-testing-action v2.2.1 -> v2.9.0
- helm/kind-action v1.3.0 -> v1.15.1

Tool versions:
- Helm (publish workflows) v3.4.0 -> v3.22.1
- Helm (lint/test workflow) v3.9.1 -> v4.3.1, matching Buildkite CI
- helm-gcs 0.3.20 -> 0.7.0
- helm-unittest v1.0.2 -> v1.2.1 (issue #790 is fixed)
- kubeconform v0.4.12 -> v0.8.0
- github-cli 2.46.0 -> 2.102.0
- Python (lint/test workflow) 3.13 -> 3.14

Charts:
- executor dind image docker:29.5.3-dind -> 29.9.1-dind

Unchanged, already current: helm-docs 1.14.2, comby 1.8.1,
sourcegraph/backport@v2. Checkov stays on Python 3.12, the newest
version checkov declares support for.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1573a-6840-7119-b6c5-6145f6b02fc1
Co-authored-by: Amp <amp@ampcode.com>
@github-actions

Copy link
Copy Markdown

@marcleblanc2 marcleblanc2 changed the title chore: update CI tooling, GitHub Actions, and dind image to current versions chore: update dependencies Oct 20, 2026
@marcleblanc2
marcleblanc2 requested a review from a team October 20, 2026 03:08
@marcleblanc2
marcleblanc2 marked this pull request as draft November 13, 2026 10:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant