Repository navigation
feat/frontend: Add separate annotations and labels for the frontend-internal Service - #1022
Draft
marcleblanc2 wants to merge 2 commits into
Draft
marcleblanc2 wants to merge 2 commits into
marcleblanc2 wants to merge 2 commits into
Conversation
marcleblanc2
force-pushed
the
marc/frontend-internal-service-labels
branch
2 times, most recently
from
November 18, 2026 20:08
318fe7b to
c4289c4
Compare
…vice
The sourcegraph-frontend-internal Service has always rendered
frontend.serviceAnnotations and frontend.serviceLabels, the same values as
the sourcegraph-frontend Service. Load balancer annotations or a service
mesh label meant for the external Service therefore also landed on the
internal ClusterIP Service.
Add frontend.internalServiceAnnotations and frontend.internalServiceLabels.
Unset, the internal Service keeps getting the frontend Service's values, so
the default render and existing releases are unchanged. Set, even to {},
they replace the inherited values.
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1902b-ece9-725c-863d-3e2bba35ee1d
…nd Service's values
The previous commit kept frontend.serviceAnnotations and
frontend.serviceLabels on the sourcegraph-frontend-internal Service unless
the new internal values were set, to leave existing releases unchanged.
Annotations and labels meant for the external Service were very likely
never wanted on the internal one, so that fallback is not worth carrying.
frontend.internalServiceAnnotations and frontend.internalServiceLabels now
default to {} and are the only values the internal Service renders.
frontend.serviceAnnotations and frontend.serviceLabels apply to the
sourcegraph-frontend Service only. The default render is unchanged.
Amp-Thread-ID: https://ampcode.com/threads/T-01a1902b-ece9-725c-863d-3e2bba35ee1d
Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/frontend-internal-service-labels
branch
from
November 18, 2026 20:32
c4289c4 to
3cd2071
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sourcegraph-frontend-internalService rendersfrontend.serviceAnnotationsandfrontend.serviceLabels, thesourcegraph-frontendService's valuesSolution
frontend.internalServiceAnnotationsandfrontend.internalServiceLabels, empty by default, are the only such values the internal Service rendersfrontend.serviceAnnotationsandfrontend.serviceLabelsnow apply to thesourcegraph-frontendService onlyUpgrade impact
frontend.serviceAnnotationsorfrontend.serviceLabelsloses them from the internal Service, in place, with no pod restartTested
tests/frontendInternalService_test.yaml; 2 of its 3 tests fail againstmain's templatehelm templatewith default values is byte-identical to feat/labels: Add labels to PVCs, ServiceAccounts, and RBAC objects #1008frontend.service*values set: onmainthey are on the internal Service, on this branch they are nothelm unittest(277 tests),helm lint, helm-docs, andkubeconform -strictpassAmp threads
Changelog
frontend.internalServiceAnnotationsandfrontend.internalServiceLabelssourcegraph-frontend-internalService no longer rendersfrontend.serviceAnnotationsandfrontend.serviceLabels