Repository navigation
[Backport 8.2.x] migrator: decouple image unit test from release-rewritten values - #1012
Merged
Merged
Conversation
Releases rewrite sourcegraph.image.repository and migrator.image.defaultTag in values.yaml to the internal registry for internal builds, so asserting the chart default index.docker.io image failed every internal release build (first hit by 8.2.0). Pin the repository and tag in the test instead, matching charts/sourcegraph/tests/imageRepository_test.yaml. Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 4f07add) Amp-Thread-ID: https://ampcode.com/threads/T-ca0eafc9-7175-4232-bd12-abd4f121842f
kalanchan
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1011 to
8.2.x. The 8.2.0 helm release needs it:DeployRepoReleaseCreatefailed on this test (build #3210), and helm promotion is on hold until it's fixed. It was cherry-picked cleanly with-x. See #1011 for the root cause.Test plan
helm unitteston this branch, for the 4 CI charts:Charts: 4 passed,Tests: 254 passed. The same fix applied tointernal/release-v8.2.0also passes (254 tests); without it,migratorfails the same way as #3210.