Skip to content

[Backport 8.2.x] migrator: decouple image unit test from release-rewritten values - #1012

Merged
michaellzc merged 1 commit into
8.2.xfrom
backport-1011-to-8.2.x
Nov 11, 2026
Merged

michaellzc merged 1 commit into
8.2.xfrom
backport-1011-to-8.2.x

Conversation

@michaellzc

Copy link
Copy Markdown
Member

Backport of #1011 to 8.2.x. The 8.2.0 helm release needs it: DeployRepoReleaseCreate failed on this test (build #3210), and helm promotion is on hold until it's fixed. It was cherry-picked cleanly with -x. See #1011 for the root cause.

Test plan

helm unittest on this branch, for the 4 CI charts: Charts: 4 passed, Tests: 254 passed. The same fix applied to internal/release-v8.2.0 also passes (254 tests); without it, migrator fails the same way as #3210.

Releases rewrite sourcegraph.image.repository and migrator.image.defaultTag
in values.yaml to the internal registry for internal builds, so asserting the
chart default index.docker.io image failed every internal release build
(first hit by 8.2.0). Pin the repository and tag in the test instead, matching
charts/sourcegraph/tests/imageRepository_test.yaml.

Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit 4f07add)
Amp-Thread-ID: https://ampcode.com/threads/T-ca0eafc9-7175-4232-bd12-abd4f121842f
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

@michaellzc
michaellzc merged commit cc733f7 into 8.2.x Nov 11, 2026
4 checks passed
@michaellzc
michaellzc deleted the backport-1011-to-8.2.x branch November 11, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants