Repository navigation
fix/redis: set Redis endpoints on the code-intel workers - #1004
Merged
Merged
Conversation
marcleblanc2
enabled auto-merge (squash)
November 11, 2026 03:39
1 task done
michaellzc
approved these changes
Nov 11, 2026
The syntactic-code-intel-worker Deployment did not set REDIS_CACHE_ENDPOINT or REDIS_STORE_ENDPOINT, so it always fell back to its built-in default redis-store:6379 and ignored redisCache.connection / redisStore.connection. On instances with external Redis that host does not exist. Use the sourcegraph.redisConnection helper and the sourcegraph.redisChecksum pod annotation, matching frontend, gitserver, searcher, and worker. Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2 Co-authored-by: Amp <amp@ampcode.com>
Checkov's CKV_SECRET_6 flagged external-redis-cache / external-redis-store as high-entropy strings. Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2 Co-authored-by: Amp <amp@ampcode.com>
Same gap as syntactic-code-intel-worker: the Deployment set no REDIS_*_ENDPOINT, so the worker used redis-store:6379 regardless of redisCache.connection / redisStore.connection. Its dbworker queue metrics reporter takes a Redis lock, which failed on instances with external Redis. Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
syntactic-worker-redis-endpoints
branch
from
November 13, 2026 05:29
997bdf2 to
a9252d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
precise-code-intel-workerandsyntactic-code-intel-workernever got the chart's Redis settings, so they always connected to the defaultredis-store:6379. With external Redis that host doesn't exist. Both workers use Redis for a periodic lock around their queue metrics.This adds the same
sourcegraph.redisConnectionenv vars andchecksum/redisannotation that frontend, gitserver, searcher, and worker already use.If you set
REDIS_*_ENDPOINTinpreciseCodeIntel.envorsyntacticCodeIntel.envas a workaround, remove it when upgrading.Checklist
Test plan
helm unittest: the Redis connection tests now cover both workers, includingexistingSecret. They fail without the template changes.helm templatewith external Redis secrets renders both env vars and the annotation on each worker.lookup redis-storeerrors. After the env vars were added by hand to the syntactic worker, traces showed it taking its Redis lock. Not deployed from this branch.