Repository navigation
Conversation
kuhe
force-pushed
the
kuhe/chore/models
branch
6 times, most recently
from
October 15, 2026 17:15
e403e39 to
1578269
Compare
Contributor
Author
|
4% serde slowdown after cold start, but we'll reclaim that performance in another PR. The SDK has to start up without going OOM first. |
kuhe
marked this pull request as ready for review
October 15, 2026 18:50
kuhe
force-pushed
the
kuhe/chore/models
branch
2 times, most recently
from
October 15, 2026 20:02
9836707 to
c68bef4
Compare
kuhe
force-pushed
the
kuhe/chore/models
branch
from
October 15, 2026 21:14
c68bef4 to
987e77b
Compare
stobrien89
requested changes
Oct 15, 2026
| if scalar is not None: | ||
| return scalar | ||
| if st == ShapeType.STRUCTURE: | ||
| target = member.expect_member_target().id.name |
Contributor
There was a problem hiding this comment.
Do we lose the namespace here?
| fields.append((field_names[i], _py_type(member))) | ||
| else: | ||
| fields.append((field_names[i], _py_type(member), spec)) | ||
| bases: tuple[type, ...] = (ModeledError,) if is_error else () |
Contributor
There was a problem hiding this comment.
Don’t modeled errors still need to extend the service’s ServiceError? Right now except ServiceError won’t catch them
Comment on lines
+452
to
+457
| return { | ||
| "serialize": serialize, | ||
| "serialize_members": serialize_members, | ||
| "deserialize": deserialize, | ||
| "_smithy_default": _smithy_default, | ||
| } |
Contributor
There was a problem hiding this comment.
Did we mean to drop deserialize_kwargs? It’s still in the stub, but it isn’t on the runtime class
kuhe
force-pushed
the
kuhe/chore/models
branch
3 times, most recently
from
October 16, 2026 14:43
d62499b to
aaf2366
Compare
kuhe
force-pushed
the
kuhe/chore/models
branch
from
October 17, 2026 18:30
aaf2366 to
6c16a24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dataclassannotations in the models.py file take up too much CPU time on initialization. As things stand, a 128mb lambda would OOM just by loading a handful of AWS SDK clients, if they are any of the somewhat large ones (not necessarily even to EC2's level).To avoid this, the PR:
models.pyideclare the classes as type interfaces onlymodels.pygenerate the classes on-demandCold-start benchmark
AWS Lambda w/ 512 MB, Python 3.12
Imports (does not instantiate) 5 generated clients at module scope: bedrock-agentcore-control, bedrock, guardduty, bedrock-agent, lambda.
Init Duration, median of 3 cold starts.