Repository navigation
docs: Fix React SDK README hook names, required props, and broken examples - #244
Open
promptless[bot] wants to merge 1 commit into
Open
promptless[bot] wants to merge 1 commit into
promptless[bot] wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep findings: No issues found, Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Why
The React SDK README has examples that reference undefined variables, use the wrong hook name, or leave out a required prop. Several table-of-contents entries are missing or point at the wrong section.
Goal
README.md: changemakeSkyflowStylestouseMakeSkyflowStyles, the namesrc/index.tsexports. Add the requiredcontainerprop to the minimalFileRenderElementexample. Fix undefinedcardNameRefandcallGetreferences and invalid optional-chaining syntax.ExpirationDateElemententries. Fix heading levels.samples/SkyflowElements/README.md: fix a dangling reference and typos, and describe 10 samples that had no description.use3DSanduseCollectListenersare exported but not documented.Testing
maincommit. Review comments on this PR link each correction to the source line that supports it.Trigger Events