Repository navigation
FIX support relative output paths in skops update - #559
Merged
adrinjalali merged 1 commit intoOct 21, 2026
Merged
Conversation
adrinjalali
approved these changes
Oct 21, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The focused path-construction fix has regression coverage for both affected modes, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes skops update for relative output paths containing directories, including --inplace.
Changes:
- Uses only the output filename when constructing the temporary path.
- Adds regression tests for both update modes and documents the fix.
| File | Description |
|---|---|
| skops/cli/tests/test_update.py | Tests relative paths with directories in both modes. |
| skops/cli/_update.py | Removes parent directories from the temporary filename. |
| docs/changes.rst | Adds a changelog entry for the fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
No existing issue.
What does this implement/fix? Explain your changes.
Fixes
skops updatefailing withFileNotFoundErrorwhen a relative output path contains a directory, including--inplace. The temporary file now uses the output filename without its parent directories.Adds regression coverage for both modes and a changelog entry.
Any other comments?
The full local test run, including doctests, and all pre-commit checks pass on macOS with Python 3.12.