Repository navigation
feat(cli): add doctor and refresh terminal UX - #231
Conversation
|
Agent verification from Codex:
|
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. a6f2f8a1-f669-484b-927d-ad081c783b4f |
|
Agent verification for
The local binary includes the repository's release verification keys. The review service returned |
|
Agent verification: the live home scan displayed 421 Skills through seven opening rows. Checked recommendation drilldown, symlink filtering, and explicit duplicate labels. Completed removal through the new navigation on a scratch fixture at 80×24. Confirmed recovery metadata, backup contents, and the durable shell summary. The home scan remained read-only. |
|
Agent verification: reproduced linked-parent misclassification and a missing broken-link report before fixing both. The live terminal fixture now shows one Skill with two linked paths, including the parent link and its raw destination. Checked 335 direct links from the earlier home inventory against the filesystem; every target matched the recorded canonical path. Four cleanup fixtures verify link-only source preservation, retarget rejection, alias deduplication, and linked-parent preservation. |
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: BLOCKED.
|
Agent verification: the live home scan visited 32,709 directories in 4.52 seconds. It retained all 10 active linked Skills stored in home app data, including skilld and copywriting. Worker-home Skills were absent. The earlier scan visited 70,503 directories; this is an observation, not a controlled benchmark. Fixtures cover configured Agent roots and stores, exclusion overrides, project-only scope, external-root containment, linked referents, and broad opt-in. |
There was a problem hiding this comment.
Open (84/100): The required quality check fails on the pull-request head.
Proof: The supplied durable Review status reports that required check "quality" fails on head e1a1e6a. This job runs lint, typecheck, build, JavaScript tests, API-contract tests, and Doctor tests, so the head has n.
Next: Inspect the failing quality-job step, repair its underlying failure, and publish a head where the required check passes.
Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy.
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: BLOCKED.
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.






🔗 Linked issue
Requested Skill discovery, cleanup, and terminal UX improvements.
❓ Type of change
📚 Description
Skills scattered across Agent targets and projects need an inventory before cleanup. Add
skilld doctorwith home-only discovery, exclude globs, content fingerprints, and separate skills.sh triage.Doctor starts with recommendations for skills.sh migration, unknown installs, ownership problems, and identical copies. Each group opens projects or folders before individual Skills. Symlink views include direct links and linked parent folders, with their destinations. Counts distinguish physical Skills from linked paths. Broken links remain visible when worktrees are included. Linked worktrees are excluded even through explicit roots and aliases. Broad home
.localdiscovery is skipped. Configured Skill roots and active symlink targets remain included without scanning adjacent app data. Explicit exclusions and scan scope still apply. Filters change the view; action reviews still list every affected target. Doctor shows scan progress and previews migration or removal before changing files. Applying an action rechecks targets, saves recovery copies, and preserves unrelated lock metadata. Migration uses verified source delivery and stops when identity or target placement cannot be established.Unify colours, spacing, narrow layouts, and keyboard focus across command output, help, pickers, approval prompts, updates, and upgrades. Doctor adds readable scan problems and full notices, plus a durable action summary after returning to the shell. Machine output retains its existing envelopes and streams.
Add the original
skilld-tui-designSkill, distilled from the reviewedtui-designand OpenShelltui-developmentSkills. Its source review records exact revisions and the adopted and rejected guidance.On this workstation, one before/after home scan fell from 25.03s to 6.74s after excluding generated paths. Both scans found 93 skilld installs and 23 skills.sh installs. Historical commit searches and project-to-global deduplication remain outside Doctor's actions. Managed Skills use the existing update workflow.